diff options
| author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2010-05-12 17:50:23 -0400 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2010-05-14 15:09:33 -0400 |
| commit | 712a4338669d7d57f952244abb608e6ac07e39da (patch) | |
| tree | 97875575e55a85ac02acc39bb7fe6a6139c71885 | |
| parent | ff8399709e41bf72b4cb145612a0f9a9f7283c83 (diff) | |
| download | talos-op-linux-712a4338669d7d57f952244abb608e6ac07e39da.tar.gz talos-op-linux-712a4338669d7d57f952244abb608e6ac07e39da.zip | |
SUNRPC: Fix xs_setup_bc_tcp()
It is a BUG for anybody to call this function without setting
args->bc_xprt. Trying to return an error value is just wrong, since the
user cannot fix this: it is a programming error, not a user error.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
| -rw-r--r-- | net/sunrpc/xprtsock.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 3d1dcdf2aef1..beefa7a3a90e 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -2442,9 +2442,6 @@ static struct rpc_xprt *xs_setup_bc_tcp(struct xprt_create *args) struct sock_xprt *transport; struct svc_sock *bc_sock; - if (!args->bc_xprt) - ERR_PTR(-EINVAL); - xprt = xs_setup_xprt(args, xprt_tcp_slot_table_entries); if (IS_ERR(xprt)) return xprt; |
