diff options
| author | Julia Lawall <julia@diku.dk> | 2010-05-26 17:58:53 +0200 |
|---|---|---|
| committer | Joel Becker <joel.becker@oracle.com> | 2010-06-15 15:43:46 -0700 |
| commit | 6469272c350872980891dbe38e81c936c43f2d9b (patch) | |
| tree | 5aee3dd3731e18ca9909338d039aacaf5ebdf7d1 | |
| parent | 7e27d6e778cd87b6f2415515d7127eba53fe5d02 (diff) | |
| download | talos-op-linux-6469272c350872980891dbe38e81c936c43f2d9b.tar.gz talos-op-linux-6469272c350872980891dbe38e81c936c43f2d9b.zip | |
fs/ocfs2/dlm: Add missing spin_unlock
Add a spin_unlock missing on the error path. Unlock as in the other code
that leads to the leave label.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression E1;
@@
* spin_lock(E1,...);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
* spin_unlock(E1,...);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
| -rw-r--r-- | fs/ocfs2/dlm/dlmdomain.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c index 6b5a492e1749..2ccad86fb590 100644 --- a/fs/ocfs2/dlm/dlmdomain.c +++ b/fs/ocfs2/dlm/dlmdomain.c @@ -1709,6 +1709,7 @@ retry: } if (dlm_protocol_compare(&dlm->fs_locking_proto, fs_proto)) { + spin_unlock(&dlm_domain_lock); mlog(ML_ERROR, "Requested locking protocol version is not " "compatible with already registered domain " |
