talos-op-linux/drivers/staging/gdm72xx, branch master

Staging: gdm72xx: Remove gdm72xx driver

2016-03-12T06:09:09+00:00

Remove support for gdm72xx driver from the kernel since Wimax is dead. [1] http://www.networkworld.com/article/2220370/4g/wimax-is-dead.html [2] http://www.androidcentral.com/sprint-confirms-wimax-shutdown-november-6-2015 Chrome OS can distribute this driver alongside their library. Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman

Staging: gdm72xx: remove duplicate condition

2016-03-05T22:48:04+00:00

We know "len" is not zero because we tested for that at the beginning of the function so this test can be removed. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

Staging: gdm72xx: underflow bug in gdm_wimax_ioctl_get_data()

2016-03-05T22:48:04+00:00

"size" here should be unsigned, otherwise we might end up trying to copy negative bytes in gdm_wimax_ioctl_get_data() resulting in an information leak. Reported-by: Alan Cox Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

staging: gdm72xx: zero out padding

2016-03-05T22:48:04+00:00

We pad the start of this buffer with 256 bytes of padding. It's not clear to me exactly what's going on or how it's used but let's zero it out. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

Staging: gdm72xx: make "len" unsigned

2016-03-05T22:48:04+00:00

We had an underflow bug here and I think I fixed it but we may as well be proactive and make "len" unsigned to be double sure. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

Staging: gdm72xx: silence underflow warning in netlink_send()

2016-03-05T22:48:04+00:00

The value of "group" comes from "idx" in __gdm_wimax_event_send(): if (sscanf(e->dev->name, "wm%d", &idx) == 1) Smatch marks sscanf values as user controlled. It's supposed to be a number in 0-30 range. We cap the upper bound but allow negatives. Fix this by making it type u16 instead. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

staging: gdm72xx: underflow in netlink_rcv_cb()

2016-03-05T22:48:04+00:00

If nlh->nlmsg_len is less than ND_IFINDEX_LEN we end up trying to memcpy a negative size. I also re-ordered slighty the condition to make it more uniform. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

Staging: gdm72xx: Remove wrapper function put_event_entry

2016-02-20T23:36:49+00:00

put_event_entry is used only once. Replace it's usage with direct call to list_add_tail(). Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman

Staging: gdm72xx: Remove unnecessary parenthesis around function pointer

2016-02-20T23:36:49+00:00

No need for the parentheses around any function pointer. Detected using checkpatch. Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman

Staging: gdm72xx: Add space around that "+", "&" and "/"

2016-02-20T23:36:49+00:00

Add missing spaces around "+", "&" and "/" to follow kernel coding style. Warning detected by checkpatch. Signed-off-by: Shraddha Barke Signed-off-by: Greg Kroah-Hartman