talos-op-linux/drivers/staging/dgnc, branch master

staging: dgnc: delete the driver

2018-10-02T22:14:14+00:00

Digi does not support it, no one has hardware for it, and no one is working on it, so let's drop it for now. If anyone wants to pick it back up, then can revert this patch. Reported-by: Lidza Louina Reported-by: Mark Hounschell Signed-off-by: Greg Kroah-Hartman

staging: dgnc: Fix Kconfig help header and text

2018-10-02T22:10:22+00:00

Replace Kconfig help header and text to match other modules. Issue found by checkpatch. Spacing adjusted to match Documentation/process/coding-style.rst. Issue reported by rdunlap@infradead.org. Reported-by: Randy Dunlap Signed-off-by: Sehro Rautenkranz Signed-off-by: Greg Kroah-Hartman

staging: dgnc: Fix a sleep-in-atomic-context bug in cls_assert_modem_signals()

2018-09-18T11:29:10+00:00

The driver may sleep with holding a spinlock. The function call path (from bottom to top) in Linux-4.17 is: [FUNC] usleep_range drivers/staging/dgnc/dgnc_cls.c, 391: usleep_range in cls_assert_modem_signals drivers/staging/dgnc/dgnc_cls.c, 449: cls_assert_modem_signals in cls_copy_data_from_queue_to_uart drivers/staging/dgnc/dgnc_cls.c, 406: _raw_spin_lock_irqsave in cls_copy_data_from_queue_to_uart To fix this bug, usleep_range() is replaced with udelay(). This bug is found by my static analysis tool DSAC. Signed-off-by: Jia-Ju Bai Signed-off-by: Greg Kroah-Hartman

staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line

2018-07-24T12:00:54+00:00

Bring the first argument to the previous line, remove a superfluous () in the second argument by using !, and align the lines to match open parenthesis. Issue found by checkpatch. Signed-off-by: Nishad Kamdar Signed-off-by: Greg Kroah-Hartman

staging: dgnc: drop unused neo_uart_struct

2018-01-17T14:02:56+00:00

Now that the "neo" portion of the driver is gone (it was never being used), drop the unused neo_uart_struct variable as well. Cc: Lidza Louina Cc: Mark Hounschell Signed-off-by: Greg Kroah-Hartman

staging: dgnc: remove "vpd" board variable

2018-01-17T14:02:56+00:00

It was only ever read from the device, and spit out to the kernel log for no good reason. So remove it, and the way it was read from the device, and the now unused "board file" callback. Cc: Lidza Louina Cc: Mark Hounschell Signed-off-by: Greg Kroah-Hartman

staging: dgnc: delete serial_num board variable

2018-01-17T14:02:56+00:00

No one was even ever setting the thing, so just remove it. Cc: Lidza Louina Cc: Mark Hounschell Signed-off-by: Greg Kroah-Hartman

staging: dgnc: delete a bunch of PCI board variables

2018-01-17T14:02:56+00:00

None of these were being used at all, only set and never used again, so remove them from the code. Cc: Lidza Louina Cc: Mark Hounschell Signed-off-by: Greg Kroah-Hartman

staging: dgnc: delete is_pci_express board type variable.

2018-01-17T14:02:56+00:00

It was only set, and never looked at, so drop the thing as no one cares about it. And when it was set, it was not even set correctly, the index it was using to read from was incorrect, so this has never even been correct... Cc: Lidza Louina Cc: Mark Hounschell Signed-off-by: Greg Kroah-Hartman

staging: dgnc: delete dpastatus board type variable.

2018-01-17T14:02:56+00:00

It was only set, and never looked at, so drop the thing as no one cares about it. Cc: Lidza Louina Cc: Mark Hounschell Signed-off-by: Greg Kroah-Hartman