talos-op-linux/drivers/rtc/rtc-max77686.c, branch v5.2

rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'

2018-11-14T09:44:43+00:00

In case of error, we return 0. This is spurious and not consistent with the other functions of the driver. Commit e115a2bf1426 has modified more than what is said in the commit message. Reverse part of it znd return an error when needed, as it was previously. Fixes: e115a2bf1426 ("rtc: max77686: stop validating rtc_time in .read_time") Signed-off-by: Christophe JAILLET Reviewed-by: Chanwoo Choi Signed-off-by: Alexandre Belloni

rtc: maxim: Add SPDX license identifiers

2018-08-14T21:38:45+00:00

Replace GPL v2.0+ license statements with SPDX license identifiers. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Alexandre Belloni

rtc: max77686: stop validating rtc_time in .read_time

2018-03-02T09:12:20+00:00

The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni

rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation

2016-03-14T16:08:27+00:00

Use macro REGMAP_IRQ_REG from regmap.h to initialise the regmap irq table for max77686 to have better coding style and improve readability. Signed-off-by: Laxman Dewangan Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alexandre Belloni

rtc: max77686: Add support for MAX20024/MAX77620 RTC IP

2016-03-14T16:08:27+00:00

Maxim Semiconductor's PMIC MAX77686 has RTC IP which is reused in the MAX77620/MAX20024 PMICs. Add support for these devices in MAX77686 RTC driver. This device does not have RTC alarm pending status outside of RTC IP. The RTC IP is having separate I2C address for its register access. Signed-off-by: Laxman Dewangan Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alexandre Belloni

rtc: max77686: move initialisation of rtc regmap, irq chip locally

2016-03-14T16:08:13+00:00

To make RTC block of MAX77686/MAX77802 as independent driver, move the registration of i2c device, regmap for register access and irq_chip for interrupt support inside the RTC driver. Removed the same initialisation from MFD driver. Having this change will allow to reuse this driver for different PMIC/devices from Maxim Semiconductor if they kept same RTC IP on different PMIC. Some of examples as PMIC MAX77620, MAX20024 where same RTC IP used and hence driver for these chips will use this driver only for RTC support. Suggested-by: Krzysztof Kozlowski Signed-off-by: Laxman Dewangan Tested-by: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas Acked-by: Lee Jones Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alexandre Belloni

rtc: max77686: avoid reference of parent device info multiple places

2016-03-14T16:08:12+00:00

Get rid of referring parent device info for register access all the places by making regmap as part of max77686 rtc device info. This will also remove the need of storing parent device info in max77686 rtc device info as this is no more required. Signed-off-by: Laxman Dewangan Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Tested-by: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas Signed-off-by: Alexandre Belloni

rtc: max77686: use rtc regmap to access RTC registers

2016-03-14T16:08:11+00:00

rtc_regmap should be used to access all RTC registers instead of parent regmap regardless of what chip or property have it. This makes the register access uniform and extendible for other chips. Signed-off-by: Laxman Dewangan Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Tested-by: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas Signed-off-by: Alexandre Belloni

rtc: max77686: fix checkpatch error

2016-03-14T16:08:11+00:00

Fix following check patch error in rtc-max77686 driver: - Alignment should match open parenthesis. - braces {} should be used on all arms of this statement. - Prefer using the BIT macro Signed-off-by: Laxman Dewangan Tested-by: Krzysztof Kozlowski Reviewed-by: Krzysztof Kozlowski Tested-by: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas Signed-off-by: Alexandre Belloni

rtc: max77686: Cleanup and reduce dmesg output

2016-02-04T22:44:15+00:00

Cleanup of entire driver of its dmesg output: 1. Remove printing of the function name, because printing device name is sufficient. This also makes the dev_err()-like functions more compact and readable (not need of line break). 2. Lower from info to debug printing of each RTC interrupt (no need to make noise on each alarm). 3. Remove dev_info() at beginning of probe because a message is already always printed by either probe failure or from registering the RTC device as /dev/rtcX. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Javier Martinez Canillas Signed-off-by: Alexandre Belloni