talos-op-linux/drivers/platform/x86/intel_pmc_ipc.c, branch master

platform/x86: intel_pmc_ipc: Switch to use driver->dev_groups

2020-01-22T16:52:27+00:00

The driver core provides support for adding additional attributes for devices via new ->dev_groups member of struct device_driver. Convert the driver to use that instead of adding the attributes manually. Suggested-by: Andy Shevchenko Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Propagate error from kstrtoul()

2020-01-22T16:52:27+00:00

kstrtoul() already returns negative error if the input was not valid so return it directly. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Use octal permissions in sysfs attributes

2020-01-22T16:52:27+00:00

This is the current preferred way so replace the S_IWUSR with the corresponding octal value. While there move the attributes to follow directly their store functions. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Get rid of unnecessary includes

2020-01-22T16:52:26+00:00

There is no point including headers that are not needed in the driver so drop them. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Drop ipc_data_readb()

2020-01-22T16:52:26+00:00

This function is not used anywhere so drop it completely. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Drop intel_pmc_gcr_read() and intel_pmc_gcr_write()

2020-01-22T16:52:26+00:00

These functions are not used anywhere so drop them completely. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Make intel_pmc_ipc_raw_cmd() static

2020-01-22T16:52:26+00:00

This function is not called outside of intel_pmc_ipc.c so we can make it static instead. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Make intel_pmc_ipc_simple_command() static

2020-01-22T16:52:26+00:00

This function is not called outside of intel_pmc_ipc.c so we can make it static instead. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Make intel_pmc_gcr_update() static

2020-01-22T16:52:26+00:00

This function is not called outside of intel_pmc_ipc.c so we can make it static instead. Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Signed-off-by: Andy Shevchenko

platform/x86: intel_pmc_ipc: Remove dev_err() usage after platform_get_irq()

2019-08-01T15:03:02+00:00

We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) | platform_get_irq_byname(E, ...) ); if ( \( ret < 0 \| ret <= 0 \) ) { ( -if (ret != -EPROBE_DEFER) -{ ... -dev_err(...); -... } | ... -dev_err(...); ) ... } // While we're here, remove braces on if statements that only have one statement (manually). Cc: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: Enric Balletbo i Serra Cc: Hans de Goede Cc: "Darren Hart (VMware)" Cc: Roman Kiryanov Cc: Vadim Pasternak Cc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd Signed-off-by: Andy Shevchenko