talos-op-linux/drivers/mtd/chips, branch master

mtd: cfi_cmdset_0002: fix delayed error detection on HyperFlash

2019-11-09T09:13:53+00:00

The commit 4844ef80305d ("mtd: cfi_cmdset_0002: Add support for polling status register") added checking for the status register error bits into chip_good() to only return 1 if these bits are 0s. Unfortunately, this means that polling using chip_good() always reaches a timeout condition when erase or program failure bits are set. Let's fully delegate the task of determining the error conditions to cfi_check_err_status() and make chip_good() only look for the Device Ready/Busy condition. Fixes: 4844ef80305d ("mtd: cfi_cmdset_0002: Add support for polling status register") Signed-off-by: Sergei Shtylyov Signed-off-by: Vignesh Raghavendra

mtd: cfi_cmdset_0002: only check errors when ready in cfi_check_err_status()

2019-11-09T09:13:41+00:00

Cypress S26K{L|S}P{128|256|512}S datasheet says that the error bits in the status register are only valid when the "device ready" bit 7 is set. Add the check for the device ready bit in cfi_check_err_status() as that function isn't always called with this bit set. Fixes: 4844ef80305d ("mtd: cfi_cmdset_0002: Add support for polling status register") Signed-off-by: Sergei Shtylyov Signed-off-by: Vignesh Raghavendra

mtd: cfi_cmdset_0002: don't free cfi->cfiq in error path of cfi_amdstd_setup()

2019-11-09T09:12:47+00:00

Else there may be a double-free problem, because cfi->cfiq will be freed by mtd_do_chip_probe() if both the two invocations of check_cmd_set() return failure. Signed-off-by: Hou Tao Reviewed-by: Richard Weinberger Signed-off-by: Vignesh Raghavendra

mtd: cfi_cmdset_*: kill useless 'ret' variable initializers

2019-11-09T09:12:09+00:00

The 'ret' local variables are typically initialized to 0 but this value is often unused, thus we can kill those initializers. Signed-off-by: Sergei Shtylyov Signed-off-by: Vignesh Raghavendra

mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()

2019-11-09T09:10:48+00:00

Use DIV_ROUND_UP() in cfi_udelay() instead of open-coding it... Doing this also helpfully gets rid of two complaints from 'scripts/checkpatch.pl --strict': CHECK: spaces preferred around that '+' (ctx:VxV) #29: FILE: drivers/mtd/chips/cfi_util.c:29: + msleep((us+999)/1000); ^ CHECK: spaces preferred around that '/' (ctx:VxV) #29: FILE: drivers/mtd/chips/cfi_util.c:29: + msleep((us+999)/1000); ^ Signed-off-by: Sergei Shtylyov Signed-off-by: Vignesh Raghavendra

mtd: cfi_cmdset_0002: Fix do_erase_chip() to get chip as erasing mode

2019-09-15T21:51:07+00:00

The chip state is set to erasing by the function after getting chip. So it should be to get chip as erasing mode at first. But previously it was to get chip as writing mode then fix as erasing. Signed-off-by: Tokunori Ikegami Cc: linux-mtd@lists.infradead.org Signed-off-by: Richard Weinberger

mtd: cfi_cmdset_0002: Disable write buffer functions if FORCE_WORD_WRITE is 1

2019-08-27T12:25:53+00:00

Some write buffer functions are not used when FORCE_WORD_WRITE is set to 1. So the compile warning messages are output if FORCE_WORD_WRITE is 1. To resolve this disable the write buffer functions if FORCE_WORD_WRITE is 1. Cc: Fabio Bettoni Co: Hauke Mehrtens Cc: Chris Packham Cc: Joakim Tjernlund Cc: linux-mtd@lists.infradead.org Signed-off-by: Tokunori Ikegami Signed-off-by: Vignesh Raghavendra

mtd: cfi_cmdset_0002: Split do_write_oneword() to reduce exit paths

2019-08-27T12:25:53+00:00

The do_write_oneword_done() is called twice at the exit paths. By splitting the retry functionality it can be reduced to call once. Cc: Fabio Bettoni Co: Hauke Mehrtens Cc: Chris Packham Cc: Joakim Tjernlund Cc: linux-mtd@lists.infradead.org Signed-off-by: Tokunori Ikegami Signed-off-by: Vignesh Raghavendra

mtd: cfi_cmdset_0002: Split wait for write buffer completion sequence

2019-08-27T12:25:53+00:00

Split wait for write completion from do_write_buffer() into separate function. Cc: Fabio Bettoni Co: Hauke Mehrtens Cc: Chris Packham Cc: Joakim Tjernlund Cc: linux-mtd@lists.infradead.org Signed-off-by: Tokunori Ikegami [vigneshr@ti.com: Reword commit message] Signed-off-by: Vignesh Raghavendra

mtd: cfi_cmdset_0002: Split write-to-buffer-reset sequence

2019-08-27T12:25:53+00:00

Just refactor to split the sequence from do_write_buffer(). Cc: Fabio Bettoni Co: Hauke Mehrtens Cc: Chris Packham Cc: Joakim Tjernlund Cc: linux-mtd@lists.infradead.org Signed-off-by: Tokunori Ikegami Signed-off-by: Vignesh Raghavendra