diff options
author | Bill Hoffa <wghoffa@us.ibm.com> | 2017-07-19 14:53:01 -0500 |
---|---|---|
committer | William A. Bryan <wilbryan@us.ibm.com> | 2017-07-22 16:29:49 -0400 |
commit | 56ecb493705fef5b2275b94329836f8690ef0865 (patch) | |
tree | 0de3ef2b3fb966c4fcc0044398d03593cab0df0b /src/occ_gpe0/firdata/lpc.c | |
parent | 7990cb411443a3d30a40f2cd101732fc353bcd38 (diff) | |
download | talos-occ-56ecb493705fef5b2275b94329836f8690ef0865.tar.gz talos-occ-56ecb493705fef5b2275b94329836f8690ef0865.zip |
PNOR Write Fixes for FIRDATA collection path
- Updated write_pnor_8B() to add ECC
- Removed memcpy calls as they cause unaligned accesses
- LPC accesses modified to only be 4 bytes at a time
Change-Id: I2bc2fddce3e652f97890962754f8dfa2e2e8d9aa
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43458
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: William A. Bryan <wilbryan@us.ibm.com>
Diffstat (limited to 'src/occ_gpe0/firdata/lpc.c')
-rw-r--r-- | src/occ_gpe0/firdata/lpc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/occ_gpe0/firdata/lpc.c b/src/occ_gpe0/firdata/lpc.c index 6544c44..7b9ffca 100644 --- a/src/occ_gpe0/firdata/lpc.c +++ b/src/occ_gpe0/firdata/lpc.c @@ -208,12 +208,11 @@ errorHndl_t lpc_read( LpcTransType i_type, do { if( o_data == NULL ) { - TRACFCOMP( "o_data is NULL!" ); + TRAC_ERR("o_data is NULL!" ); l_err = -2; break; } - /* Generate the full absolute LPC address */ l_addr = checkAddr( i_type, i_addr ); @@ -366,6 +365,7 @@ errorHndl_t lpc_write( LpcTransType i_type, //is expected to be left aligned //adding (size - 1) <-- to incorporate reading more than one byte //multiply by 8 to convert from byte to bits + l_shift_amount = (7 - ((l_addr & 0x7) + (i_size-1))) * 8; l_data = (l_write_data << l_shift_amount); |