cleanup proc and pss dirs from TODOs

Change-Id: If7b7f175425301a4517f164d8b692067369b43f1
RTC: 163365
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/35863
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William A. Bryan <wilbryan@us.ibm.com>
Reviewed-by: Martha Broyles <mbroyles@us.ibm.com>
Reviewed-by: Wael El-Essawy <welessa@us.ibm.com>

2 files changed, 7 insertions, 14 deletions

diff --git a/src/occ_405/pss/apss.c b/src/occ_405/pss/apss.c
index ae4d100..e979477 100755
--- a/src/occ_405/pss/apss.c
+++ b/src/occ_405/pss/apss.c
@@ -41,9 +41,11 @@
 // Threshold for calling out the redundant APSS
 #define MAX_BACKUP_FAILURES  8
 
+// G_gpio_config: configuration for APSS GPIO pins
 // Configure both GPIOs (directoin/drive/interrupts): All Input, All 1's, No Interrupts
 const apssGpioConfigStruct_t G_gpio_config[2] = { {0x00, 0xFF, 0x00}, {0x00, 0xFF, 0x00} };
 
+// G_apss_mode_config: system parms needed to select correct mode command options
 // Configure streaming of: APSS Mode, 16 ADCs, 2 GPIOs
 const apssModeConfigStruct_t G_apss_mode_config = { APSS_MODE_COMPOSITE, 16, 2 };
 
@@ -84,7 +86,8 @@ volatile bool G_ApssPwrMeasCompleted = FALSE;
 //
 // Name: dumpHexString
 //
-// Description: TODO Add description
+// Description: translates passed binary data into hexadecimal ASCII formatted
+//              readable text, and dumps it to simics stdio console.
 //
 // End Function Specification
 #if ( (!defined(NO_TRAC_STRINGS)) && defined(TRAC_TO_SIMICS) )
@@ -892,9 +895,8 @@ bool apss_gpio_get(uint8_t i_pin_number, uint8_t *o_pin_value)
         // Check if G_dcom_slv_inbox_rx is valid.
         // The default value is all 0, so check if it's no-zero
         bool l_dcom_data_valid = FALSE;
-// TEMP -- NO DCOM IN PHASE1
-/*
         int i=0;
+
         for(;i<sizeof(G_dcom_slv_inbox_rx);i++)
         {
             if( ((char*)&G_dcom_slv_inbox_rx)[i] != 0 )
@@ -903,7 +905,7 @@ bool apss_gpio_get(uint8_t i_pin_number, uint8_t *o_pin_value)
               break;
             }
         }
-*/
+
         if( l_dcom_data_valid == TRUE)
         {
             uint8_t l_gpio_port = i_pin_number/NUM_OF_APSS_PINS_PER_GPIO_PORT;
@@ -985,9 +987,6 @@ errlHndl_t initialize_apss(void)
         TRAC_INFO("initialize_apss: GPE_apss_initialize_gpio completed w/rc=0x%08x",
                   l_request.request.completion_state);
 
-        //TODO: The ipc command will return "SUCCESS" even if an internal PPE failure
-        //      occurs.  Make sure that checking for rc as seen below, is good enough.
-
         // Only continue if initializaton completed without any errors.
         if ((ASYNC_REQUEST_STATE_COMPLETE == l_request.request.completion_state) &&
             (G_gpe_apss_initialize_gpio_args.error.rc == ERRL_RC_SUCCESS))
diff --git a/src/occ_405/pss/apss.h b/src/occ_405/pss/apss.h
index 0047cfa..6808f48 100644
--- a/src/occ_405/pss/apss.h
+++ b/src/occ_405/pss/apss.h
@@ -67,12 +67,6 @@ struct apssPwrMeasStruct
 } __attribute__ ((__packed__));
 typedef struct apssPwrMeasStruct apssPwrMeasStruct_t;
 
-// @TODO - Does G_gpio_config and G_apss_mode_config need to be used outside of APSS?  If not I will remove from .h
-// G_gpio_config: configuration for APSS GPIO pins (default all input, all 1's, not int)
-extern const apssGpioConfigStruct_t G_gpio_config[NUM_OF_APSS_GPIO_PORTS];
-// G_apss_mode_config: system parms needed to select correct mode command options
-extern const apssModeConfigStruct_t G_apss_mode_config;
-
 // G_apss_pwr_meas: power, temp and GPIO readings that OCC gathers from APSS every tick
 extern apssPwrMeasStruct_t G_apss_pwr_meas;
 
@@ -90,7 +84,7 @@ void task_apss_start_pwr_meas(task_t *i_self);
 void task_apss_continue_pwr_meas(task_t *i_self);
 void task_apss_complete_pwr_meas(task_t *i_self);
 
-void apss_test_pwr_meas(); // @temp cc - used to test measurements
+void apss_test_pwr_meas(); // used to test measurements
 void reformat_meas_data();
 bool apss_gpio_get(uint8_t i_pin_number, uint8_t *o_pin_value);
 errlHndl_t initialize_apss(void);