diff options
| author | Prachi Gupta <pragupta@us.ibm.com> | 2017-07-21 14:28:02 -0500 |
|---|---|---|
| committer | William A. Bryan <wilbryan@us.ibm.com> | 2017-07-22 16:30:38 -0400 |
| commit | ca84830b6d1811a78c538f51bde34c269806f00a (patch) | |
| tree | decc61b7a182d485392fde4bcbddc387727bdee4 | |
| parent | 56ecb493705fef5b2275b94329836f8690ef0865 (diff) | |
| download | talos-occ-ca84830b6d1811a78c538f51bde34c269806f00a.tar.gz talos-occ-ca84830b6d1811a78c538f51bde34c269806f00a.zip | |
rt_xstop_analysis: minor cleanups/tweaks
- Fix fir data collection functions' description
- change pk trace buffer size to 256 bytes
- add trace to main.c to indicate we failed to schedule
fir data collection job
- add comment to clarify pnor data buffer changes
Change-Id: Ie6f68dd30b4382df95adae1fe420abcabf67033c
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43449
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: William A. Bryan <wilbryan@us.ibm.com>
| -rwxr-xr-x | src/occ_405/main.c | 7 | ||||
| -rw-r--r-- | src/occ_gpe0/firdata/pnorData_common.h | 1 | ||||
| -rw-r--r-- | src/occ_gpe0/gpe_util.c | 2 | ||||
| -rw-r--r-- | src/ppe/pk/trace/pk_trace.h | 2 |
4 files changed, 8 insertions, 4 deletions
diff --git a/src/occ_405/main.c b/src/occ_405/main.c index 0298ab4..da0819d 100755 --- a/src/occ_405/main.c +++ b/src/occ_405/main.c @@ -153,7 +153,6 @@ FIR_HEAP_BUFFER(uint8_t G_fir_heap[FIR_HEAP_SECTION_SIZE]); FIR_PARMS_BUFFER(uint8_t G_fir_data_parms[FIR_PARMS_SECTION_SIZE]); uint32_t G_fir_master = FIR_OCC_NOT_FIR_MASTER; bool G_fir_collection_request_created = FALSE; -GPE_BUFFER(ipc_scom_op_t G_scom_op); GpeRequest G_fir_collection_request; /* @@ -1716,7 +1715,11 @@ void Main_thread_routine(void *private) { G_fir_collection_request_created = TRUE; TRAC_IMP("fir data collection: scheduling gpe request"); - gpe_request_schedule(&G_fir_collection_request); + l_rc = gpe_request_schedule(&G_fir_collection_request); + { + TRAC_IMP("failed to schedule fir data collection job"); + } + L_fir_collection_completed = TRUE; G_fir_collection_required = FALSE; } diff --git a/src/occ_gpe0/firdata/pnorData_common.h b/src/occ_gpe0/firdata/pnorData_common.h index 8ec238c..88698c8 100644 --- a/src/occ_gpe0/firdata/pnorData_common.h +++ b/src/occ_gpe0/firdata/pnorData_common.h @@ -142,6 +142,7 @@ static inline PNOR_Trgt_t PNOR_getTrgt( uint32_t i_trgtType, uint32_t i_chipPos, /** Information for a normal register. */ /* NOTE: This structure is 4-byte word aligned. */ +//The order matters here due to hardware limitations on the GPE typedef struct __attribute__((packed)) { uint64_t val; /** 64-bit value */ diff --git a/src/occ_gpe0/gpe_util.c b/src/occ_gpe0/gpe_util.c index c97baa1..0879fc3 100644 --- a/src/occ_gpe0/gpe_util.c +++ b/src/occ_gpe0/gpe_util.c @@ -223,7 +223,7 @@ void ipc_scom_operation(ipc_msg_t* cmd, void* arg) * * Name: ipc_fir_collection * - * Description: Does a getscom or putscom for the 405 + * Description: Does fir data collection in case of a checkstop * * End Function Specification */ diff --git a/src/ppe/pk/trace/pk_trace.h b/src/ppe/pk/trace/pk_trace.h index 49f6871..b93029a 100644 --- a/src/ppe/pk/trace/pk_trace.h +++ b/src/ppe/pk/trace/pk_trace.h @@ -34,7 +34,7 @@ #define PK_TRACE_VERSION 2 #ifndef PK_TRACE_SZ -#define PK_TRACE_SZ 4096 //@pragupta_todo -- only for debug +#define PK_TRACE_SZ 256 #endif //Fail compilation if size is not a power of 2 |
