summaryrefslogtreecommitdiffstats
path: root/common/cmd_ext2.c
Commit message (Collapse)AuthorAgeFilesLines
* cmd_usage(): simplify return code handlingWolfgang Denk2010-07-241-6/+4
| | | | | | | | | | | | | | | | Lots of code use this construct: cmd_usage(cmdtp); return 1; Change cmd_usage() let it return 1 - then we can replace all these ocurrances by return cmd_usage(cmdtp); This fixes a few places with incorrect return code handling, too. Signed-off-by: Wolfgang Denk <wd@denx.de>
* Make sure that argv[] argument pointers are not modified.Wolfgang Denk2010-07-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The hush shell dynamically allocates (and re-allocates) memory for the argument strings in the "char *argv[]" argument vector passed to commands. Any code that modifies these pointers will cause serious corruption of the malloc data structures and crash U-Boot, so make sure the compiler can check that no such modifications are being done by changing the code into "char * const argv[]". This modification is the result of debugging a strange crash caused after adding a new command, which used the following argument processing code which has been working perfectly fine in all Unix systems since version 6 - but not so in U-Boot: int main (int argc, char **argv) { while (--argc > 0 && **++argv == '-') { /* ====> */ while (*++*argv) { switch (**argv) { case 'd': debug++; break; ... default: usage (); } } } ... } The line marked "====>" will corrupt the malloc data structures and usually cause U-Boot to crash when the next command gets executed by the shell. With the modification, the compiler will prevent this with an error: increment of read-only location '*argv' N.B.: The code above can be trivially rewritten like this: while (--argc > 0 && **++argv == '-') { char *arg = *argv; while (*++arg) { switch (*arg) { ... Signed-off-by: Wolfgang Denk <wd@denx.de> Acked-by: Mike Frysinger <vapier@gentoo.org>
* Fix ext2load return codeWolfgang Denk2009-07-281-36/+38
| | | | | | | | | | Make the ext2load command return 0 on success (instead of the file length). Also fix output format (get rid of random newlines) and some coding style issues (long lines etc.). Signed-off-by: Wolfgang Denk <wd@denx.de>
* General help message cleanupWolfgang Denk2009-06-121-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many of the help messages were not really helpful; for example, many commands that take no arguments would not print a correct synopsis line, but "No additional help available." which is not exactly wrong, but not helpful either. Commit ``Make "usage" messages more helpful.'' changed this partially. But it also became clear that lots of "Usage" and "Help" messages (fields "usage" and "help" in struct cmd_tbl_s respective) were actually redundant. This patch cleans this up - for example: Before: => help dtt dtt - Digital Thermometer and Thermostat Usage: dtt - Read temperature from digital thermometer and thermostat. After: => help dtt dtt - Read temperature from Digital Thermometer and Thermostat Usage: dtt Signed-off-by: Wolfgang Denk <wd@denx.de>
* cmd_ext2.c: fix compile warningsWolfgang Denk2009-04-281-2/+2
| | | | | | | | | Get rid of these warnings: cmd_ext2.c:247: warning: format '%ld' expects type 'long int', but argument 2 has type 'int' cmd_ext2.c:248: warning: format '%lX' expects type 'long unsigned int', but argument 3 has type 'int' Signed-off-by: Wolfgang Denk <wd@denx.de>
* fs: Fix the wrong type of varGao Guanhua2009-04-281-1/+2
| | | | | | | | | The filelen should be signed type, not unsigned type. otherwise, The condition as below never take. if (filelen < 0) Signed-off-by: Gao Guanhua <B22826@freescale.com> Signed-off-by: Dave Liu <daveliu@freescale.com>
* Command usage cleanupPeter Tyser2009-01-281-2/+2
| | | | | | | | Remove command name from all command "usage" fields and update common/command.c to display "name - usage" instead of just "usage". Also remove newlines from command usage fields. Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
* Standardize command usage messages with cmd_usage()Peter Tyser2009-01-281-2/+2
| | | | Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
* rename CFG_ macros to CONFIG_SYSJean-Christophe PLAGNIOL-VILLARD2008-10-181-1/+1
| | | | Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
* CONFIG_EFI_PARTITION: Added support for EFI partition in cmd_ext2fs.crichardretanubun2008-10-181-2/+2
| | | | | Added support for CONFIG_EFI_PARTITION to ext2 commands. Signed-off-by: Richard Retanubun <RichardRetanubun@RugggedCom.com>
* [BUILD] conditionally compile common/cmd_*.c in common/MakefileGrant Likely2007-11-201-4/+0
| | | | | | | Modify common/Makefile to conditionally compile the cmd_*.c files based on the board config. Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
* common/cmd_[af]*: Remove obsolete references to CONFIG_COMMANDS.Jon Loeliger2007-07-081-3/+3
| | | | Signed-off-by: Jon Loeliger <jdl@freescale.com>
* common/cmd_[a-f]* : Augment CONFIG_COMMANDS tests with defined(CONFIG_CMD_*).Jon Loeliger2007-07-041-2/+2
| | | | | | | | | | | | | | This is a compatibility step that allows both the older form and the new form to co-exist for a while until the older can be removed entirely. All transformations are of the form: Before: #if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT) After: #if (CONFIG_COMMANDS & CFG_CMD_AUTOSCRIPT) || defined(CONFIG_CMD_AUTOSCRIPT) Signed-off-by: Jon Loeliger <jdl@freescale.com>
* [PATCH 1_4] Merge common get_dev() routines for block devicesGrant Likely2007-02-201-37/+3
| | | | | | | Each of the filesystem drivers duplicate the get_dev routine. This change merges them into a single function in part.c Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
* Merge with /home/sr/git/u-bootWolfgang Denk2005-10-171-1/+1
|\
| * Fix identification on ext2ls help entryStefan Roese2005-10-141-1/+1
| | | | | | | | Patch by Stefan Roese, 14 Oct 2005
* | Cleanup for GCC-4.xWolfgang Denk2005-10-131-1/+1
|/
* * Fix get_partition_info() parameter error in all other callswdenk2005-03-041-1/+4
| | | | | | | | | | (common/cmd_ide.c, common/cmd_reiser.c, common/cmd_scsi.c). * Enable USB and IDE support for INKA4x0 board * Patch by Andrew Dyer, 28 February 2005: fix ext2load passing an incorrect pointer to get_partition_info() resulting in load failure for devices other than 0
* * Patch by Cajus Hahn, 04 Feb 2005:wdenk2005-02-041-1/+1
| | | | | | | | - don't insist on leading '/' for filename in ext2load - set default partition to useful value (1) in ext2load * Patch by Andrew Dyer, 08 Jan 2005: fix wrong return codes in ext2 code
* ext2fs support addedstroese2004-12-161-0/+294
OpenPOWER on IntegriCloud