path: root/scripts/
diff options
authorMasahiro Yamada <>2014-08-16 00:59:26 +0900
committerTom Rini <>2014-08-21 12:01:11 -0400
commit31e2141d5ad76b55e4e34ee7241adc1c3d9ef099 (patch)
tree59661ae5e29aea1057b1a669d54d70f88edb6615 /scripts/
parent6933b5c9f3b6844b5fc3b81b3c8157cb17eaea3e (diff)
tools, scripts: refactor error-out statements of Python scripts
In Python, sys.exit() function can also take an object other than an integer. If an integer is given to the argument, Python exits with the return code of it. If a non-integer argument is given, Python outputs it to stderr and exits with the return code of 1. That means, print >> sys.stderr, "Blah Blah" sys.exit(1) is equivalent to sys.exit("Blah Blah") The latter is a useful shorthand. Note: Some error messages in Buildman and Patman were output to stdout. But they should go to stderr. They are also fixed by this commit. This is a nice side effect. Signed-off-by: Masahiro Yamada <> Acked-by: Simon Glass <>
Diffstat (limited to 'scripts/')
1 files changed, 1 insertions, 6 deletions
diff --git a/scripts/ b/scripts/
index 749abcb7a5..69a470e51f 100755
--- a/scripts/
+++ b/scripts/
@@ -194,11 +194,6 @@ def rmdirs(*dirs):
exception.errno != errno.ENOTEMPTY:
-def error(msg):
- """Output the given argument to stderr and exit with return code 1."""
- print >> sys.stderr, msg
- sys.exit(1)
def run_command(command, callback_on_error=None):
"""Run the given command in a sub-shell (and exit if it fails).
@@ -211,7 +206,7 @@ def run_command(command, callback_on_error=None):
if retcode:
if callback_on_error:
- error("'%s' Failed" % command)
+ sys.exit("'%s' Failed" % command)
def run_make_config(cmd, objdir, callback_on_error=None):
"""Run the make command in a sub-shell (and exit if it fails).
OpenPOWER on IntegriCloud