path: root/lib
diff options
authorStephen Warren <>2016-02-10 15:16:19 -0700
committerTom Rini <>2016-02-15 12:04:47 -0500
commit15b51878bec835c315c80529a0c4d147d681c8e9 (patch)
treea0d67e87792995867f5452196798fc2e0ee4df87 /lib
parenta094c9211e98f51668d84430b5fe081faa9d4a32 (diff)
Makefile: remove BUILD_TAG from KBUILD_CFLAGS
If BUILD_TAG is part of KBUILD_CFLAGS, then any time the value changes, all files get rebuilt. In a continuous integration environment, the value will change every build. This wastes time, assuming that incremental builds would otherwise occur. To solve this, remove BUILD_TAG from KBUILD_CFLAGS and add it to CFLAGS for just the one file that uses it. This does have the disadvantage that if any other files want to use the flag, we'll need to duplicate this custom CFLAGS setup logic. However, it seems unlikely we'll need this. An alternative would be to add BUILD_TAG to the "local version" and remove the special case code from display_options.c. However, that would affect the format of the U-Boot signon message, which may negatively affect people looking for specific data there. The approach of using file-specific CFLAGS was suggested by Masahiro Yamada. Signed-off-by: Stephen Warren <> Reviewed-by: Tom Rini <> Reviewed-by: Masahiro Yamada <> Acked-by: Simon Glass <>
Diffstat (limited to 'lib')
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/Makefile b/lib/Makefile
index dd36f25b2a..1e21bcc4c7 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -67,6 +67,7 @@ obj-$(CONFIG_ADDR_MAP) += addr_map.o
obj-y += hashtable.o
obj-y += errno.o
obj-y += display_options.o
+CFLAGS_display_options.o := $(if $(BUILD_TAG),-DBUILD_TAG='"$(BUILD_TAG)"')
obj-$(CONFIG_BCH) += bch.o
obj-y += crc32.o
obj-y += ctype.o
OpenPOWER on IntegriCloud