summaryrefslogtreecommitdiffstats
path: root/drivers/usb
diff options
context:
space:
mode:
authorPeng Fan <van.freenix@gmail.com>2016-06-20 09:43:09 +0800
committerMarek Vasut <marex@denx.de>2016-06-25 00:57:10 +0200
commit57de41e9c944af8d2c7bfcc2358414c5dd8c39df (patch)
treeea6f64511797228060b3321430861e66e7c04f3d /drivers/usb
parent429ff4473b8b1a98c528608a127de833ece0496a (diff)
downloadtalos-obmc-uboot-57de41e9c944af8d2c7bfcc2358414c5dd8c39df.tar.gz
talos-obmc-uboot-57de41e9c944af8d2c7bfcc2358414c5dd8c39df.zip
ehci: mx7: fix otg id detection
The USBNC_PHYCFG2_ACAENB bit should be cleared to enable the OTG ID detection, not set it. When the bit is set, the ACA Resistance Detection is enabled, which disables the OTG ID detection, because the internal pull up is off. Signed-off-by: Ye Li <ye.li@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Diffstat (limited to 'drivers/usb')
-rw-r--r--drivers/usb/host/ehci-mx6.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c
index cc3b11ce4e..069f116ed2 100644
--- a/drivers/usb/host/ehci-mx6.c
+++ b/drivers/usb/host/ehci-mx6.c
@@ -208,8 +208,11 @@ static void usb_power_config(int index)
(0x10000 * index) + USBNC_OFFSET);
void __iomem *phy_cfg2 = (void __iomem *)(&usbnc->phy_cfg2);
- /* Enable usb_otg_id detection */
- setbits_le32(phy_cfg2, USBNC_PHYCFG2_ACAENB);
+ /*
+ * Clear the ACAENB to enable usb_otg_id detection,
+ * otherwise it is the ACA detection enabled.
+ */
+ clrbits_le32(phy_cfg2, USBNC_PHYCFG2_ACAENB);
}
int usb_phy_mode(int port)
OpenPOWER on IntegriCloud