summaryrefslogtreecommitdiffstats
path: root/drivers/usb/musb-new/musb_uboot.c
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2015-06-17 21:33:54 +0200
committerSimon Glass <sjg@chromium.org>2015-07-21 17:39:37 -0600
commit15837236386191f2a26706b5ee56cdb4ab28e6d5 (patch)
treedd84bb180cbecfe09bbab7bd1950ba7d87485a1b /drivers/usb/musb-new/musb_uboot.c
parentfd1bd21bf07d0770bff7b477d501b706dac9987d (diff)
downloadtalos-obmc-uboot-15837236386191f2a26706b5ee56cdb4ab28e6d5.tar.gz
talos-obmc-uboot-15837236386191f2a26706b5ee56cdb4ab28e6d5.zip
musb: Allow musb_platform_enable to return an error code
Allow musb_platform_enable to return an error code and propagate it up to usb_lowlevel_init(). This allows moving the checks for an external vbus being present to be moved from platform_init to platform_enable, so that the user can unplug a charger, plug in a host adapter with a usb-device, do a "usb reset" and have things working. This also allows adding a check for the id-pin to platform_enable, so that it can short circuit the 1s delay in usb_lowlevel_init() when no host cable is plugged in and thus waiting for a device to show up is useless. Note that all the changes to code shared with the kernel are wrapped in the kernel. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'drivers/usb/musb-new/musb_uboot.c')
-rw-r--r--drivers/usb/musb-new/musb_uboot.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/usb/musb-new/musb_uboot.c b/drivers/usb/musb-new/musb_uboot.c
index 1bf676c589..70e87c9f0d 100644
--- a/drivers/usb/musb-new/musb_uboot.c
+++ b/drivers/usb/musb-new/musb_uboot.c
@@ -217,13 +217,17 @@ int usb_lowlevel_init(int index, enum usb_init_type init, void **controller)
void *mbase;
/* USB spec says it may take up to 1 second for a device to connect */
unsigned long timeout = get_timer(0) + 1000;
+ int ret;
if (!host) {
printf("MUSB host is not registered\n");
return -ENODEV;
}
- musb_start(host);
+ ret = musb_start(host);
+ if (ret)
+ return ret;
+
mbase = host->mregs;
do {
if (musb_readb(mbase, MUSB_DEVCTL) & MUSB_DEVCTL_HM)
OpenPOWER on IntegriCloud