diff options
| author | Wolfgang Denk <wd@denx.de> | 2014-01-31 09:28:25 +0100 |
|---|---|---|
| committer | Tom Rini <trini@ti.com> | 2014-02-19 10:47:36 -0500 |
| commit | f7740f7712b8638f08b83a7e5d00bc1d6bb086a9 (patch) | |
| tree | d26cf7d00a07159bcf1518ed3650a13e9a846c5f | |
| parent | 9137d19bdd321b810275f2e967e3a39165a4e8de (diff) | |
| download | talos-obmc-uboot-f7740f7712b8638f08b83a7e5d00bc1d6bb086a9.tar.gz talos-obmc-uboot-f7740f7712b8638f08b83a7e5d00bc1d6bb086a9.zip | |
EXT4: Fix number base handling of "ext4write" command
Unlike other commands (for example, "fatwrite"), ext4write would
interpret the "sizebytes" as decimal number. This is not only
inconsistend and unexpected to most users, it also breaks usage
like this:
tftp ${addr} ${name}
ext4write mmc 0:2 ${addr} ${filename} ${filesize}
Change this to use the standard notation of base 16 input format.
See also commit b770e88
WARNING: this is a change to the user interface!!
Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Uma Shankar <uma.shankar@samsung.com>
Cc: Stephen Warren <swarren@nvidia.com>
| -rw-r--r-- | common/cmd_ext4.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/cmd_ext4.c b/common/cmd_ext4.c index 8289d25b06..68b047ba6a 100644 --- a/common/cmd_ext4.c +++ b/common/cmd_ext4.c @@ -79,8 +79,8 @@ int do_ext4_write(cmd_tbl_t *cmdtp, int flag, int argc, /* get the address in hexadecimal format (string to int) */ ram_address = simple_strtoul(argv[3], NULL, 16); - /* get the filesize in base 10 format */ - file_size = simple_strtoul(argv[5], NULL, 10); + /* get the filesize in hexadecimal format */ + file_size = simple_strtoul(argv[5], NULL, 16); /* set the device as block device */ ext4fs_set_blk_dev(dev_desc, &info); |
