diff options
| author | Andrew Gabbasov <andrew_gabbasov@mentor.com> | 2013-05-30 04:47:38 +0000 |
|---|---|---|
| committer | Stefano Babic <sbabic@denx.de> | 2013-06-03 13:25:46 +0200 |
| commit | 0c54f4b7c81dc0234ec4a96d0986b7f5321a7680 (patch) | |
| tree | 138fad631599d5d8c471076afb4ec6d5bb4e4b3c | |
| parent | a1f67807ff806ffb3873c9f0c49bedcb0c6fca70 (diff) | |
| download | talos-obmc-uboot-0c54f4b7c81dc0234ec4a96d0986b7f5321a7680.tar.gz talos-obmc-uboot-0c54f4b7c81dc0234ec4a96d0986b7f5321a7680.zip | |
mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal
The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro
(shifted and or'ed with chip select), so it's incorrect to pass
that macro directly as an argument to gpio_direction_output() call.
Also, SPI driver sets the direction and initial value of a gpio,
used as a chip select signal, before any actual activity happens
on the bus.
So, it is safe to just remove the gpio_direction_output call,
that works incorrectly, thus making no effect, anyway.
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Tested-by: Robert Winkler <robert.winkler@boundarydevices.com>
Acked-by: Dirk Behme <dirk.behme@de.bosch.com>
| -rw-r--r-- | board/boundary/nitrogen6x/nitrogen6x.c | 1 | ||||
| -rw-r--r-- | board/freescale/mx6qsabrelite/mx6qsabrelite.c | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c index e155556ce2..8f0f9b8de2 100644 --- a/board/boundary/nitrogen6x/nitrogen6x.c +++ b/board/boundary/nitrogen6x/nitrogen6x.c @@ -336,7 +336,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = { void setup_spi(void) { - gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1); imx_iomux_v3_setup_multiple_pads(ecspi1_pads, ARRAY_SIZE(ecspi1_pads)); } diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c index 8ce054e428..862bc3099d 100644 --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c @@ -308,7 +308,6 @@ iomux_v3_cfg_t const ecspi1_pads[] = { void setup_spi(void) { - gpio_direction_output(CONFIG_SF_DEFAULT_CS, 1); imx_iomux_v3_setup_multiple_pads(ecspi1_pads, ARRAY_SIZE(ecspi1_pads)); } |
