diff options
authorDirk Behme <>2013-07-15 15:58:27 +0200
committerStefano Babic <>2013-07-24 13:01:18 +0200
commit04c79cbd5f8f773aa7823feec6e77862e7e6426f (patch)
parent5434caf5ba32d0779f309d7a8d13e985dc667f5b (diff)
mxc_gpio: Correct the GPIO handling in gpio_direction_output()
Setting the direction and an output value should be done by First, set the desired output value. Then, switch to output. If this is done in the inverse order, like at the moment, there can be a glitch on the GPIO line while switching first the old output value and aftwards the new one. Fix this by inverting the order of the direction/set_value calls. Signed-off-by: Dirk Behme <> Acked-by: Stefano Babic <>
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpio/mxc_gpio.c b/drivers/gpio/mxc_gpio.c
index a3880641f0..1d820d4c3e 100644
--- a/drivers/gpio/mxc_gpio.c
+++ b/drivers/gpio/mxc_gpio.c
@@ -143,10 +143,10 @@ int gpio_direction_input(unsigned gpio)
int gpio_direction_output(unsigned gpio, int value)
- int ret = mxc_gpio_direction(gpio, MXC_GPIO_DIRECTION_OUT);
+ int ret = gpio_set_value(gpio, value);
if (ret < 0)
return ret;
- return gpio_set_value(gpio, value);
+ return mxc_gpio_direction(gpio, MXC_GPIO_DIRECTION_OUT);
OpenPOWER on IntegriCloud