From 2d85ec8acb01601a216b6c591cab63bfaacd2083 Mon Sep 17 00:00:00 2001 From: Wei Yongjun Date: Sat, 27 Jan 2018 08:10:59 +0000 Subject: oradax: Fix return value check in dax_attach() In case of error, the function class_create() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: dd0273284c74 ("sparc64: Oracle DAX driver") Signed-off-by: Wei Yongjun Signed-off-by: David S. Miller --- drivers/sbus/char/oradax.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'drivers/sbus') diff --git a/drivers/sbus/char/oradax.c b/drivers/sbus/char/oradax.c index 10452ae18ef1..03dc04739225 100644 --- a/drivers/sbus/char/oradax.c +++ b/drivers/sbus/char/oradax.c @@ -336,9 +336,9 @@ static int __init dax_attach(void) } cl = class_create(THIS_MODULE, DAX_NAME); - if (cl == NULL) { + if (IS_ERR(cl)) { dax_err("class_create failed"); - ret = -ENXIO; + ret = PTR_ERR(cl); goto class_error; } -- cgit v1.2.1