diff options
| author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2009-08-06 20:57:41 +0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-08-09 12:54:34 +0200 |
| commit | 1c222bce7dd0cb9578b4c5cd3874a74f1db497c3 (patch) | |
| tree | 51c8263de9d6e7480df56646ca4654e2a7d6f42b /tools | |
| parent | 1953287bfe8afcbbd235bd6c42c9df06d52438dc (diff) | |
| download | talos-obmc-linux-1c222bce7dd0cb9578b4c5cd3874a74f1db497c3.tar.gz talos-obmc-linux-1c222bce7dd0cb9578b4c5cd3874a74f1db497c3.zip | |
perf tools: Fix multi-counter stat bug caused by incorrect reading of perf.data file header
Brice Goglin reported that only the first result from a
multi-counter perf record --stat run is accurate, the
rest looks bogus.
A silly mistake made us re-read the first attribute for
every recorded attribute.
Reported-by: Brice Goglin <Brice.Goglin@inria.fr>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Tested-by: Brice Goglin <Brice.Goglin@inria.fr>
Cc: paulus@samba.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/header.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 450384b3bbe5..95a44bcfc2dc 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -213,9 +213,10 @@ struct perf_header *perf_header__read(int fd) for (i = 0; i < nr_attrs; i++) { struct perf_header_attr *attr; - off_t tmp = lseek(fd, 0, SEEK_CUR); + off_t tmp; do_read(fd, &f_attr, sizeof(f_attr)); + tmp = lseek(fd, 0, SEEK_CUR); attr = perf_header_attr__new(&f_attr.attr); |
