diff options
| author | Shuah Khan (Samsung OSG) <shuah@kernel.org> | 2018-05-04 12:15:52 -0600 |
|---|---|---|
| committer | Shuah Khan (Samsung OSG) <shuah@kernel.org> | 2018-05-30 15:29:06 -0600 |
| commit | 39d69997e4060bdd6fd7df4219ab3a2cb0669276 (patch) | |
| tree | b0ae7c8f40600e6cc78c83a3f8b14d27d4143e97 /tools/testing/selftests/membarrier | |
| parent | 113812868c40c5bb09b0e2cc7d168dee5649952f (diff) | |
| download | talos-obmc-linux-39d69997e4060bdd6fd7df4219ab3a2cb0669276.tar.gz talos-obmc-linux-39d69997e4060bdd6fd7df4219ab3a2cb0669276.zip | |
selftests: membarrier: return Kselftest Skip code for skipped tests
When membarrier test is skipped because of unmet dependencies and/or
unsupported configuration, it exits with error which is treated as a
fail by the Kselftest framework. This leads to false negative result
even when the test could not be run.
Change it to return kselftest skip code when a test gets skipped to
clearly report that the test could not be run.
Change it to use ksft_exit_skip() when the test is skipped.
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
Diffstat (limited to 'tools/testing/selftests/membarrier')
| -rw-r--r-- | tools/testing/selftests/membarrier/membarrier_test.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/tools/testing/selftests/membarrier/membarrier_test.c b/tools/testing/selftests/membarrier/membarrier_test.c index 22bffd55a523..6793f8ecc8e7 100644 --- a/tools/testing/selftests/membarrier/membarrier_test.c +++ b/tools/testing/selftests/membarrier/membarrier_test.c @@ -293,10 +293,9 @@ static int test_membarrier_query(void) } ksft_exit_fail_msg("sys_membarrier() failed\n"); } - if (!(ret & MEMBARRIER_CMD_GLOBAL)) { - ksft_test_result_fail("sys_membarrier() CMD_GLOBAL query failed\n"); - ksft_exit_fail_msg("sys_membarrier is not supported.\n"); - } + if (!(ret & MEMBARRIER_CMD_GLOBAL)) + ksft_exit_skip( + "sys_membarrier unsupported: CMD_GLOBAL not found.\n"); ksft_test_result_pass("sys_membarrier available\n"); return 0; |
