diff options
author | Hui Peng <benquike@163.com> | 2018-12-25 18:11:52 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-01-13 09:51:06 +0100 |
commit | 6c8c16479b2363972d02bc6a4be132a9a9acd17e (patch) | |
tree | 843fe1501506e2dfe2ad231e309afa0dc79fc411 /sound/usb/card.c | |
parent | b389f9c4c97ac438174b9409b372208dea62821f (diff) | |
download | talos-obmc-linux-6c8c16479b2363972d02bc6a4be132a9a9acd17e.tar.gz talos-obmc-linux-6c8c16479b2363972d02bc6a4be132a9a9acd17e.zip |
ALSA: usb-audio: Fix an out-of-bound read in create_composite_quirks
commit cbb2ebf70daf7f7d97d3811a2ff8e39655b8c184 upstream.
In `create_composite_quirk`, the terminating condition of for loops is
`quirk->ifnum < 0`. So any composite quirks should end with `struct
snd_usb_audio_quirk` object with ifnum < 0.
for (quirk = quirk_comp->data; quirk->ifnum >= 0; ++quirk) {
.....
}
the data field of Bower's & Wilkins PX headphones usb device device quirks
do not end with {.ifnum = -1}, wihch may result in out-of-bound read.
This Patch fix the bug by adding an ending quirk object.
Fixes: 240a8af929c7 ("ALSA: usb-audio: Add a quirck for B&W PX headphones")
Signed-off-by: Hui Peng <benquike@163.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/usb/card.c')
0 files changed, 0 insertions, 0 deletions