diff options
author | Eldad Zack <eldad@fogrefinery.com> | 2013-04-05 20:49:46 +0200 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2013-04-07 09:44:08 +0200 |
commit | 889d66848b12d891248b03abcb2a42047f8e172a (patch) | |
tree | 8a64d578be6020598ebd256f6b8c5406b900ab7d /kernel/time/tick-broadcast.c | |
parent | 868211db6df96ddae411fcd800502725beef8387 (diff) | |
download | talos-obmc-linux-889d66848b12d891248b03abcb2a42047f8e172a.tar.gz talos-obmc-linux-889d66848b12d891248b03abcb2a42047f8e172a.zip |
ALSA: usb-audio: fix endianness bug in snd_nativeinstruments_*
The usb_control_msg() function expects __u16 types and performs
the endianness conversions by itself.
However, in three places, a conversion is performed before it is
handed over to usb_control_msg(), which leads to a double conversion
(= no conversion):
* snd_usb_nativeinstruments_boot_quirk()
* snd_nativeinstruments_control_get()
* snd_nativeinstruments_control_put()
Caught by sparse:
sound/usb/mixer_quirks.c:512:38: warning: incorrect type in argument 6 (different base types)
sound/usb/mixer_quirks.c:512:38: expected unsigned short [unsigned] [usertype] index
sound/usb/mixer_quirks.c:512:38: got restricted __le16 [usertype] <noident>
sound/usb/mixer_quirks.c:543:35: warning: incorrect type in argument 5 (different base types)
sound/usb/mixer_quirks.c:543:35: expected unsigned short [unsigned] [usertype] value
sound/usb/mixer_quirks.c:543:35: got restricted __le16 [usertype] <noident>
sound/usb/mixer_quirks.c:543:56: warning: incorrect type in argument 6 (different base types)
sound/usb/mixer_quirks.c:543:56: expected unsigned short [unsigned] [usertype] index
sound/usb/mixer_quirks.c:543:56: got restricted __le16 [usertype] <noident>
sound/usb/quirks.c:502:35: warning: incorrect type in argument 5 (different base types)
sound/usb/quirks.c:502:35: expected unsigned short [unsigned] [usertype] value
sound/usb/quirks.c:502:35: got restricted __le16 [usertype] <noident>
Signed-off-by: Eldad Zack <eldad@fogrefinery.com>
Acked-by: Daniel Mack <zonque@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'kernel/time/tick-broadcast.c')
0 files changed, 0 insertions, 0 deletions