diff options
| author | Mark Nelson <markn@au1.ibm.com> | 2008-11-13 21:37:41 +1100 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-11-13 11:59:48 +0100 |
| commit | 3ff68a6a106c362a6811d3e51bced58e6fc87de7 (patch) | |
| tree | 9a0a10ff49f7453d26afcced211307c818fd9fa9 /kernel/irq | |
| parent | f131e2436ddbac2527bb2d6297a823aae4b024f8 (diff) | |
| download | talos-obmc-linux-3ff68a6a106c362a6811d3e51bced58e6fc87de7.tar.gz talos-obmc-linux-3ff68a6a106c362a6811d3e51bced58e6fc87de7.zip | |
genirq: __irq_set_trigger: change pr_warning to pr_debug
Commit 0c5d1eb77a8be917b638344a22afe1398236482b (genirq: record trigger
type) caused powerpc platforms that had no set_type() function in their
struct irq_chip to spew out warnings about "No set_type function for
IRQ...". This warning isn't necessarily justified though because the
generic powerpc platform code calls set_irq_type() (which in turn calls
__irq_set_trigger) with information from the device tree to establish
the interrupt mappings, regardless of whether the PIC can actually set
a type.
A platform's irq_chip might not have a set_type function for a variety
of reasons, for example: the platform may have the type essentially
hard-coded, or as in the case for Cell interrupts are just messages
past around that have no real concept of type, or the platform
could even have a virtual PIC as on the PS3.
Signed-off-by: Mark Nelson <markn@au1.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/irq')
| -rw-r--r-- | kernel/irq/manage.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 435861284e4c..801addda3c43 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -365,7 +365,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq, * IRQF_TRIGGER_* but the PIC does not support multiple * flow-types? */ - pr_warning("No set_type function for IRQ %d (%s)\n", irq, + pr_debug("No set_type function for IRQ %d (%s)\n", irq, chip ? (chip->name ? : "unknown") : "unknown"); return 0; } |
