diff options
| author | Jan Kara <jack@suse.cz> | 2014-02-21 11:19:04 +0100 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2014-02-22 02:02:28 +0100 |
| commit | 0dc83bd30b0bf5410c0933cfbbf8853248eff0a9 (patch) | |
| tree | 66b8f3ebdd4a6c0de6f82e449c7e037170e26b81 /fs/xfs/xfs_super.c | |
| parent | 1362f4ea20fa63688ba6026e586d9746ff13a846 (diff) | |
| download | talos-obmc-linux-0dc83bd30b0bf5410c0933cfbbf8853248eff0a9.tar.gz talos-obmc-linux-0dc83bd30b0bf5410c0933cfbbf8853248eff0a9.zip | |
Revert "writeback: do not sync data dirtied after sync start"
This reverts commit c4a391b53a72d2df4ee97f96f78c1d5971b47489. Dave
Chinner <david@fromorbit.com> has reported the commit may cause some
inodes to be left out from sync(2). This is because we can call
redirty_tail() for some inode (which sets i_dirtied_when to current time)
after sync(2) has started or similarly requeue_inode() can set
i_dirtied_when to current time if writeback had to skip some pages. The
real problem is in the functions clobbering i_dirtied_when but fixing
that isn't trivial so revert is a safer choice for now.
CC: stable@vger.kernel.org # >= 3.13
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/xfs/xfs_super.c')
| -rw-r--r-- | fs/xfs/xfs_super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index f317488263dd..d971f4932b5d 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -913,7 +913,7 @@ xfs_flush_inodes( struct super_block *sb = mp->m_super; if (down_read_trylock(&sb->s_umount)) { - sync_inodes_sb(sb, jiffies); + sync_inodes_sb(sb); up_read(&sb->s_umount); } } |
