diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2008-01-24 01:53:19 +0100 |
---|---|---|
committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2008-01-30 22:22:26 +0100 |
commit | 5a8a1bcd15dfb9f177f3605fe6b9ba2bef2bf55a (patch) | |
tree | f74aad717dc774991e866400179c90064e6eaa0d /drivers/video | |
parent | 14dc992aa782f8759c6d117d4322db62f62600ce (diff) | |
download | talos-obmc-linux-5a8a1bcd15dfb9f177f3605fe6b9ba2bef2bf55a.tar.gz talos-obmc-linux-5a8a1bcd15dfb9f177f3605fe6b9ba2bef2bf55a.zip |
firewire: fw-sbp2: use device generation, not card generation
There was a small window where a login or reconnect job could use an
already updated card generation with an outdated node ID. We have to
use the fw_device.generation here, not the fw_card.generation, because
the generation must never be newer than the node ID when we emit a
transaction. This cannot be guaranteed with fw_card.generation.
Furthermore, the target's and initiator's node IDs can be obtained from
fw_device and fw_card. Dereferencing their underlying topology objects
is not necessary.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Verified in concert with subsequent memory barriers patch to fix 'giving
up on config rom' issues on multiple system and drive combinations that
were previously affected.
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
Diffstat (limited to 'drivers/video')
0 files changed, 0 insertions, 0 deletions