diff options
| author | Roger Quadros <rogerq@ti.com> | 2015-08-13 13:28:42 +0300 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2015-09-14 10:15:08 -0500 |
| commit | 762982db33b23029e98c844611e2e8beeb75bc0d (patch) | |
| tree | a6d375a11508a4321f50131817febf69e5388922 /drivers/usb | |
| parent | 523d5daf86e5e8b540bdc91e090197b5665f0519 (diff) | |
| download | talos-obmc-linux-762982db33b23029e98c844611e2e8beeb75bc0d.tar.gz talos-obmc-linux-762982db33b23029e98c844611e2e8beeb75bc0d.zip | |
usb: phy: phy-generic: Fix reset behaviour on legacy boot
The gpio-desc migration done in v4.0 caused a regression
with legacy boots due to reversed reset logic.
e.g. omap3-beagle USB host breaks on legacy boot.
Request the reset GPIO with GPIOF_ACTIVE_LOW flag so that
it matches the driver logic and pin behaviour.
Fixes: e9f2cefb0cdc ("usb: phy: generic: migrate to gpio_desc")
Cc: <stable@vger.kernel.org> # 4.0+
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/phy/phy-generic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/phy/phy-generic.c b/drivers/usb/phy/phy-generic.c index ec6ecd03269c..5320cb8642cb 100644 --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -232,7 +232,8 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop, clk_rate = pdata->clk_rate; needs_vcc = pdata->needs_vcc; if (gpio_is_valid(pdata->gpio_reset)) { - err = devm_gpio_request_one(dev, pdata->gpio_reset, 0, + err = devm_gpio_request_one(dev, pdata->gpio_reset, + GPIOF_ACTIVE_LOW, dev_name(dev)); if (!err) nop->gpiod_reset = |
