diff options
| author | Lee Jones <lee.jones@linaro.org> | 2013-08-21 12:47:03 +0100 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2013-08-27 15:05:39 -0500 |
| commit | 0f2aa8caeaa043f6cbe6281eb72efba5ff860904 (patch) | |
| tree | e4168d0fa3373bb94899c04ec751ca7a9d4ae409 /drivers/usb/musb/ux500_dma.c | |
| parent | ffb62a14c7b6109ca4ee9bb360ad867b294acddc (diff) | |
| download | talos-obmc-linux-0f2aa8caeaa043f6cbe6281eb72efba5ff860904.tar.gz talos-obmc-linux-0f2aa8caeaa043f6cbe6281eb72efba5ff860904.zip | |
usb: musb: ux500: Add check for NULL board data
Dan Carpenter's automatic Smatch checker found an anomaly in the ux500
MUSB driver, whereby board data was checked before use in all but one
occasion. It is believed that it needs to be checked every time.
Smatch complaint:
drivers/usb/musb/ux500_dma.c:335 ux500_dma_controller_start()
error: we previously assumed 'data' could be null (see line 313)
Cc: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/musb/ux500_dma.c')
| -rw-r--r-- | drivers/usb/musb/ux500_dma.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/musb/ux500_dma.c b/drivers/usb/musb/ux500_dma.c index e51dd9b88e71..3700e9713258 100644 --- a/drivers/usb/musb/ux500_dma.c +++ b/drivers/usb/musb/ux500_dma.c @@ -333,7 +333,9 @@ static int ux500_dma_controller_start(struct ux500_dma_controller *controller) if (!ux500_channel->dma_chan) ux500_channel->dma_chan = dma_request_channel(mask, - data->dma_filter, + data ? + data->dma_filter : + NULL, param_array[ch_num]); if (!ux500_channel->dma_chan) { |
