diff options
| author | Michal Sojka <sojka@merica.cz> | 2014-09-24 22:43:19 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-09-25 16:58:50 +0200 |
| commit | 304f7e5e1d08fa2f5674c1323bd0ebd806c86b81 (patch) | |
| tree | 0d69327f14a23a66061fc9d39dee1ec7c6b56932 /drivers/usb/gadget/udc/fsl_qe_udc.c | |
| parent | 3fc2aa5522ab958374d93ef5d2e12df7ee233c91 (diff) | |
| download | talos-obmc-linux-304f7e5e1d08fa2f5674c1323bd0ebd806c86b81.tar.gz talos-obmc-linux-304f7e5e1d08fa2f5674c1323bd0ebd806c86b81.zip | |
usb: gadget: Refactor request completion
Use the recently introduced usb_gadget_giveback_request() in favor of
direct invocation of the completion routine.
All places in drivers/usb/ matching "[-.]complete(" were replaced with a
call to usb_gadget_giveback_request(). This was compile-tested with all
ARM drivers enabled and runtime-tested for musb.
Signed-off-by: Michal Sojka <sojka@merica.cz>
Acked-by: Felipe Balbi <balbi@ti.com>
Tested-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget/udc/fsl_qe_udc.c')
| -rw-r--r-- | drivers/usb/gadget/udc/fsl_qe_udc.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c index 732430804841..dd18ea38e391 100644 --- a/drivers/usb/gadget/udc/fsl_qe_udc.c +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c @@ -118,10 +118,7 @@ static void done(struct qe_ep *ep, struct qe_req *req, int status) ep->stopped = 1; spin_unlock(&udc->lock); - /* this complete() should a func implemented by gadget layer, - * eg fsg->bulk_in_complete() */ - if (req->req.complete) - req->req.complete(&ep->ep, &req->req); + usb_gadget_giveback_request(&ep->ep, &req->req); spin_lock(&udc->lock); @@ -2728,4 +2725,3 @@ module_platform_driver(udc_driver); MODULE_DESCRIPTION(DRIVER_DESC); MODULE_AUTHOR(DRIVER_AUTHOR); MODULE_LICENSE("GPL"); - |
