diff options
author | Rabin Vincent <rabin.vincent@stericsson.com> | 2012-05-21 13:38:42 +0530 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-06-14 17:10:08 -0700 |
commit | 2fc46915ecfbc51afcf995901f6ade7c3d503a25 (patch) | |
tree | 8b7b2a931020acdd349e2eb793f4e8da85239d37 /drivers/tty/serial/pxa.c | |
parent | 057eb856eda1d957c0f1155eaa90739221f809a7 (diff) | |
download | talos-obmc-linux-2fc46915ecfbc51afcf995901f6ade7c3d503a25.tar.gz talos-obmc-linux-2fc46915ecfbc51afcf995901f6ade7c3d503a25.zip |
vt: fix race in vt_waitactive()
pm_restore_console() is called from the suspend/resume path, and this
calls vt_move_to_console(), which calls vt_waitactive().
There's a race in this path which causes the process which requests the
suspend to sleep indefinitely waiting for an event which already
happened:
P1 P2
vt_move_to_console()
set_console()
schedule_console_callback()
vt_waitactive()
check n == fg_console +1
console_callback()
switch_screen()
vt_event_post() // no waiters
vt_event_wait() // forever
Fix the race by ensuring we're registered for the event before we check
if it's already completed.
Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/pxa.c')
0 files changed, 0 insertions, 0 deletions