diff options
| author | Andy Lutomirski <luto@kernel.org> | 2016-02-15 08:32:37 -0800 |
|---|---|---|
| committer | Darren Hart <dvhart@linux.intel.com> | 2016-03-23 10:05:46 -0700 |
| commit | 4d340c6b9cc7e6e5f6ad4fc27e837863015cdf5b (patch) | |
| tree | c3ce0d07d267a4fed87142af3644557902cde9e5 /drivers/platform/x86/dell-rbtn.c | |
| parent | a464afb9581f6a9eabce8a4aa0c70cb71e6bf4d9 (diff) | |
| download | talos-obmc-linux-4d340c6b9cc7e6e5f6ad4fc27e837863015cdf5b.tar.gz talos-obmc-linux-4d340c6b9cc7e6e5f6ad4fc27e837863015cdf5b.zip | |
dell-rbtn: Add a comment about the XPS 13 9350
On the XPS 13 9350, the dell-rbtn mechanism has a new device id, and
the DSDT turns it off if a new enough _OSI is supported. Add a
comment about why we don't bother supporting it.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Diffstat (limited to 'drivers/platform/x86/dell-rbtn.c')
| -rw-r--r-- | drivers/platform/x86/dell-rbtn.c | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/drivers/platform/x86/dell-rbtn.c b/drivers/platform/x86/dell-rbtn.c index cd410e392550..b51a2008d782 100644 --- a/drivers/platform/x86/dell-rbtn.c +++ b/drivers/platform/x86/dell-rbtn.c @@ -217,6 +217,21 @@ static void rbtn_notify(struct acpi_device *device, u32 event); static const struct acpi_device_id rbtn_ids[] = { { "DELRBTN", 0 }, { "DELLABCE", 0 }, + + /* + * This driver can also handle the "DELLABC6" device that + * appears on the XPS 13 9350, but that device is disabled + * by the DSDT unless booted with acpi_osi="!Windows 2012" + * acpi_osi="!Windows 2013". Even if we boot that and bind + * the driver, we seem to have inconsistent behavior in + * which NetworkManager can get out of sync with the rfkill + * state. + * + * On the XPS 13 9350 and similar laptops, we're not supposed to + * use DELLABC6 at all. Instead, we handle the rfkill button + * via the intel-hid driver. + */ + { "", 0 }, }; |
