diff options
| author | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> | 2014-04-19 08:51:43 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-04-24 12:53:38 -0700 |
| commit | 743bb387a1edbf1ebbba6cf77c1af3e488886c39 (patch) | |
| tree | af51f66f28ac16b87bd8d4dbe344cfeec4d7905a /drivers/phy/phy-core.c | |
| parent | 907aa3aa8dbb5437696776d40caeea245c8ba3bd (diff) | |
| download | talos-obmc-linux-743bb387a1edbf1ebbba6cf77c1af3e488886c39.tar.gz talos-obmc-linux-743bb387a1edbf1ebbba6cf77c1af3e488886c39.zip | |
phy: fix kernel oops in phy_lookup()
The kernel oopses in phy_lookup() due to 'phy->init_data' being NULL if we
register PHYs from a device tree probing driver and then call phy_get() on a
device that has no representation in the device tree (e.g. a PCI device).
Checking the pointer before dereferening it and skipping an interation if
it's NULL prevents this kernel oops.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/phy/phy-core.c')
| -rw-r--r-- | drivers/phy/phy-core.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index 623b71c54b3e..c64a2f3b2d62 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -64,6 +64,9 @@ static struct phy *phy_lookup(struct device *device, const char *port) class_dev_iter_init(&iter, phy_class, NULL, NULL); while ((dev = class_dev_iter_next(&iter))) { phy = to_phy(dev); + + if (!phy->init_data) + continue; count = phy->init_data->num_consumers; consumers = phy->init_data->consumers; while (count--) { |
