summaryrefslogtreecommitdiffstats
path: root/drivers/net/dsa
diff options
context:
space:
mode:
authorGustavo A. R. Silva <garsilva@embeddedor.com>2017-05-11 22:11:29 -0500
committerDavid S. Miller <davem@davemloft.net>2017-05-12 12:14:40 -0400
commit9fc3e4dc67fde953fd26adb3cea8f92597810b64 (patch)
tree0caa6782bf5c84ed852c9d1b637b8f994bb74cb1 /drivers/net/dsa
parentdbc2b5e9a09e9a6664679a667ff81cff6e5f2641 (diff)
downloadtalos-obmc-linux-9fc3e4dc67fde953fd26adb3cea8f92597810b64.tar.gz
talos-obmc-linux-9fc3e4dc67fde953fd26adb3cea8f92597810b64.zip
net: dsa: mv88e6xxx: add default case to switch
Add default case to switch in order to avoid any chance of using an uninitialized variable _low_, in case s->type does not match any of the listed case values. Addresses-Coverity-ID: 1398130 Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/dsa')
-rw-r--r--drivers/net/dsa/mv88e6xxx/chip.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 19581d783d8e..d034d8cd7d22 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -849,6 +849,9 @@ static uint64_t _mv88e6xxx_get_ethtool_stat(struct mv88e6xxx_chip *chip,
mv88e6xxx_g1_stats_read(chip, reg, &low);
if (s->sizeof_stat == 8)
mv88e6xxx_g1_stats_read(chip, reg + 1, &high);
+ break;
+ default:
+ return UINT64_MAX;
}
value = (((u64)high) << 16) | low;
return value;
OpenPOWER on IntegriCloud