summaryrefslogtreecommitdiffstats
path: root/drivers/media/platform/exynos4-is/fimc-is.c
diff options
context:
space:
mode:
authorDmitry Torokhov <dtor@chromium.org>2014-11-14 19:09:50 -0300
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2014-11-25 12:47:13 -0200
commit9a7a848df1995f05f750b4ed491ac80a459c912f (patch)
tree0c7dcef36238ac33caaee4e11361e2ef876c023a /drivers/media/platform/exynos4-is/fimc-is.c
parent460c8a7c25fef0712abdeeefd07bf02a8e8cb9e1 (diff)
downloadtalos-obmc-linux-9a7a848df1995f05f750b4ed491ac80a459c912f.tar.gz
talos-obmc-linux-9a7a848df1995f05f750b4ed491ac80a459c912f.zip
[media] exynos4-is: fix error handling of irq_of_parse_and_map
Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works. Signed-off-by: Dmitry Torokhov <dtor@chromium.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/platform/exynos4-is/fimc-is.c')
-rw-r--r--drivers/media/platform/exynos4-is/fimc-is.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c
index 22162b2567da..3d49ce03b176 100644
--- a/drivers/media/platform/exynos4-is/fimc-is.c
+++ b/drivers/media/platform/exynos4-is/fimc-is.c
@@ -814,9 +814,9 @@ static int fimc_is_probe(struct platform_device *pdev)
return -ENOMEM;
is->irq = irq_of_parse_and_map(dev->of_node, 0);
- if (is->irq < 0) {
+ if (!is->irq) {
dev_err(dev, "no irq found\n");
- return is->irq;
+ return -EINVAL;
}
ret = fimc_is_get_clocks(is);
OpenPOWER on IntegriCloud