summaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/rockchip/inno_hdmi.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2016-02-26 00:30:29 +0300
committerMark Yao <mark.yao@rock-chips.com>2016-05-03 14:11:22 +0800
commit2743becb3338cf012dbe7b70c6c39bbac81cc101 (patch)
tree17542bb98dea1af2e5ff6704f8e4745e3a8338a0 /drivers/gpu/drm/rockchip/inno_hdmi.c
parent69b007968e7519cf1e44920f4578054c9e0fbdc3 (diff)
downloadtalos-obmc-linux-2743becb3338cf012dbe7b70c6c39bbac81cc101.tar.gz
talos-obmc-linux-2743becb3338cf012dbe7b70c6c39bbac81cc101.zip
drm/rockchip: inno_hdmi: fix an error code
We were accidentally returning PTR_ERR(NULL) which means success when we wanted to return a negative error code. Fixes: 412d4ae6b7a5 ('drm/rockchip: hdmi: add Innosilicon HDMI support') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Yakir Yang <ykk@rock-chips.com>
Diffstat (limited to 'drivers/gpu/drm/rockchip/inno_hdmi.c')
-rw-r--r--drivers/gpu/drm/rockchip/inno_hdmi.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index 10d62fff22f1..f25244199626 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -855,8 +855,9 @@ static int inno_hdmi_bind(struct device *dev, struct device *master,
hdmi->ddc = inno_hdmi_i2c_adapter(hdmi);
if (IS_ERR(hdmi->ddc)) {
+ ret = PTR_ERR(hdmi->ddc);
hdmi->ddc = NULL;
- return PTR_ERR(hdmi->ddc);
+ return ret;
}
/*
OpenPOWER on IntegriCloud