diff options
author | nikolay@redhat.com <nikolay@redhat.com> | 2013-02-18 14:09:42 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-02-19 00:51:09 -0500 |
commit | 0896341a44bf04bf6149d9307fe4686006f3eee1 (patch) | |
tree | ea26f8337c05dadb0b93107a440ad4e95257a178 /drivers/char/dtlk.c | |
parent | 7341a73c12b6133aaf3dade95942041043b11ba3 (diff) | |
download | talos-obmc-linux-0896341a44bf04bf6149d9307fe4686006f3eee1.tar.gz talos-obmc-linux-0896341a44bf04bf6149d9307fe4686006f3eee1.zip |
bonding: fix bond_release_all inconsistencies
This patch fixes the following inconsistencies in bond_release_all:
- IFF_BONDING flag is not stripped from slaves
- MTU is not restored
- no netdev notifiers are sent
Instead of trying to keep bond_release and bond_release_all in sync
I think we can re-use bond_release as the environment for calling it
is correct (RTNL is held). I have been running tests for the past
week and they came out successful. The only way for bond_release to fail
is for the slave to be attached in a different bond or to not be a slave
but that cannot happen as RTNL is held and no slave manipulations can be
achieved.
V2: As suggested bond_release is renamed to __bond_release_one with a
new parameter "all" introduced so to avoid calling unnecessary code while
destroying a bond, and a wrapper for it called bond_release is created
because of ndo_del_link. bond_release_all() is removed.
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/char/dtlk.c')
0 files changed, 0 insertions, 0 deletions