diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2016-09-27 17:10:29 +0200 |
|---|---|---|
| committer | Geert Uytterhoeven <geert+renesas@glider.be> | 2016-11-10 10:10:25 +0100 |
| commit | 1da1b3628df34a2a5e38b70c8551770aadce969d (patch) | |
| tree | ba730b41516efc7d3d1d31bc8ccc9284da13838a /drivers/base/soc.c | |
| parent | 1001354ca34179f3db924eb66672442a173147dc (diff) | |
| download | talos-obmc-linux-1da1b3628df34a2a5e38b70c8551770aadce969d.tar.gz talos-obmc-linux-1da1b3628df34a2a5e38b70c8551770aadce969d.zip | |
base: soc: Early register bus when needed
If soc_device_register() is called before soc_bus_register(), it crashes
with a NULL pointer dereference.
soc_bus_register() is already a core_initcall(), but drivers/base/ is
entered later than e.g. drivers/pinctrl/ and drivers/soc/. Hence there
are several subsystems that may need to know SoC revision information,
while it's not so easy to initialize the SoC bus even earlier using an
initcall.
To fix this, let soc_device_register() register the bus early if that
hasn't happened yet.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Diffstat (limited to 'drivers/base/soc.c')
| -rw-r--r-- | drivers/base/soc.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/drivers/base/soc.c b/drivers/base/soc.c index b63f23e6ad61..028cef377fd4 100644 --- a/drivers/base/soc.c +++ b/drivers/base/soc.c @@ -113,6 +113,12 @@ struct soc_device *soc_device_register(struct soc_device_attribute *soc_dev_attr struct soc_device *soc_dev; int ret; + if (!soc_bus_type.p) { + ret = bus_register(&soc_bus_type); + if (ret) + goto out1; + } + soc_dev = kzalloc(sizeof(*soc_dev), GFP_KERNEL); if (!soc_dev) { ret = -ENOMEM; @@ -156,6 +162,9 @@ void soc_device_unregister(struct soc_device *soc_dev) static int __init soc_bus_register(void) { + if (soc_bus_type.p) + return 0; + return bus_register(&soc_bus_type); } core_initcall(soc_bus_register); |
