diff options
| author | Zachary Amsden <zach@vmware.com> | 2007-03-05 00:30:43 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-03-05 07:57:53 -0800 |
| commit | c6b36e9a3c57b73c7a6bdf787baa55f21195bba9 (patch) | |
| tree | 3e9e745420dc2f33f19140dbfcc34d8c042c675d /arch/i386 | |
| parent | 772205f62ebcce2d60bfa5166f56c78044afab7d (diff) | |
| download | talos-obmc-linux-c6b36e9a3c57b73c7a6bdf787baa55f21195bba9.tar.gz talos-obmc-linux-c6b36e9a3c57b73c7a6bdf787baa55f21195bba9.zip | |
[PATCH] vmi: smp fixes
Critical fixes for SMP.
Fix a couple functions which needed to be __devinit and fix a bogus parameter
to AP startup that just so happened to work because the low virtual mapping of
memory was still established.
Signed-off-by: Zachary Amsden <zach@vmware.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch/i386')
| -rw-r--r-- | arch/i386/kernel/vmi.c | 7 | ||||
| -rw-r--r-- | arch/i386/kernel/vmitime.c | 2 |
2 files changed, 5 insertions, 4 deletions
diff --git a/arch/i386/kernel/vmi.c b/arch/i386/kernel/vmi.c index af8c54245f9a..245d091d659d 100644 --- a/arch/i386/kernel/vmi.c +++ b/arch/i386/kernel/vmi.c @@ -525,13 +525,14 @@ void vmi_pmd_clear(pmd_t *pmd) #endif #ifdef CONFIG_SMP -struct vmi_ap_state ap; extern void setup_pda(void); -static void __init /* XXX cpu hotplug */ +static void __devinit vmi_startup_ipi_hook(int phys_apicid, unsigned long start_eip, unsigned long start_esp) { + struct vmi_ap_state ap; + /* Default everything to zero. This is fine for most GPRs. */ memset(&ap, 0, sizeof(struct vmi_ap_state)); @@ -570,7 +571,7 @@ vmi_startup_ipi_hook(int phys_apicid, unsigned long start_eip, /* Protected mode, paging, AM, WP, NE, MP. */ ap.cr0 = 0x80050023; ap.cr4 = mmu_cr4_features; - vmi_ops.set_initial_ap_state(__pa(&ap), phys_apicid); + vmi_ops.set_initial_ap_state((u32)&ap, phys_apicid); } #endif diff --git a/arch/i386/kernel/vmitime.c b/arch/i386/kernel/vmitime.c index d21779749838..8dc72d575666 100644 --- a/arch/i386/kernel/vmitime.c +++ b/arch/i386/kernel/vmitime.c @@ -243,7 +243,7 @@ void __init vmi_timer_setup_boot_alarm(void) /* Initialize the time accounting variables for an AP on an SMP system. * Also, set the local alarm for the AP. */ -void __init vmi_timer_setup_secondary_alarm(void) +void __devinit vmi_timer_setup_secondary_alarm(void) { int cpu = smp_processor_id(); |
