diff options
| author | Borislav Petkov <borislav.petkov@amd.com> | 2011-09-21 14:10:43 +0200 |
|---|---|---|
| committer | Borislav Petkov <bp@alien8.de> | 2012-03-19 12:03:58 +0100 |
| commit | 5e8e19bf6c3c9d8ecf74e2a7fdae99a76949bdf6 (patch) | |
| tree | f31689e646f1badffab20574e301c162f07b653a /Documentation/edac.txt | |
| parent | 11b0a31473edf74b70ab6f8fe857b61bff82d7cc (diff) | |
| download | talos-obmc-linux-5e8e19bf6c3c9d8ecf74e2a7fdae99a76949bdf6.tar.gz talos-obmc-linux-5e8e19bf6c3c9d8ecf74e2a7fdae99a76949bdf6.zip | |
EDAC: Correct scrub rate API
The original scrub rate API definition states that if scrub rate
accessors are not implemented, a negative value (-1) should be written
to the sysfs file (/sys/devices/system/edac/mc/mc<N>/sdram_scrub_rate,
where N is the memory controller number on the system). This is
counter-intuitive and awkward at the very least because, when setting
the scrub rate, userspace has to write to sysfs and then read it back to
check error status of the operation.
As Tony notes, best it would be to not have the sdram_scrub_rate in
sysfs if scrub rate support is not implemented. It is too late about
that and a bunch of drivers on a bunch of arches would need to be
changed and tested which is not a trivial task ATM.
Instead, settle for the next best thing of returning -ENODEV when
implementation is missing and -EINVAL when there was an error
encountered while setting the scrub rate.
Reported-by: Han Pingtian <phan@redhat.com>
Cc: Tony Luck <tony.luck@intel.com>
Link: http://lkml.kernel.org/r/20110916105856.GA13253@hpt.nay.redhat.com
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
Diffstat (limited to 'Documentation/edac.txt')
| -rw-r--r-- | Documentation/edac.txt | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Documentation/edac.txt b/Documentation/edac.txt index 249822cde82b..fdcc49fad8e1 100644 --- a/Documentation/edac.txt +++ b/Documentation/edac.txt @@ -334,8 +334,8 @@ Sdram memory scrubbing rate: Reading the file will return the actual scrubbing rate employed. - If configuration fails or memory scrubbing is not implemented, the value - of the attribute file will be -1. + If configuration fails or memory scrubbing is not implemented, accessing + that attribute will fail. |
