diff options
| author | Lv Zheng <lv.zheng@intel.com> | 2015-12-25 11:22:32 +0800 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2015-12-28 01:29:41 +0100 |
| commit | 59adb3988ebeec012343317ac783d6a7935e0c83 (patch) | |
| tree | d4d2290d0a9afece99faa1bb173c58f74306bc15 | |
| parent | ec74765d9f592715292b8b33689a6af6db4cf5c5 (diff) | |
| download | talos-obmc-linux-59adb3988ebeec012343317ac783d6a7935e0c83.tar.gz talos-obmc-linux-59adb3988ebeec012343317ac783d6a7935e0c83.zip | |
ACPI / debugger: Fix a redundant mutex unlock issue in acpi_aml_open()
Fix a double mutex_unlock() issue where acpi_initialize_debugger() is
called with the mutex already unlocked.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/acpi/acpi_dbg.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c index e8d1698c15bb..15e4604efba7 100644 --- a/drivers/acpi/acpi_dbg.c +++ b/drivers/acpi/acpi_dbg.c @@ -514,7 +514,7 @@ static int acpi_aml_open(struct inode *inode, struct file *file) if (ACPI_FAILURE(status)) { pr_err("Failed to initialize debugger.\n"); ret = -EINVAL; - goto err_lock; + goto err_exit; } pr_debug("Debugger thread initialized.\n"); @@ -531,6 +531,7 @@ err_lock: acpi_aml_active_reader = NULL; } mutex_unlock(&acpi_aml_io.lock); +err_exit: return ret; } |
