summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHannes Reinecke <hare@suse.de>2013-01-30 09:26:13 +0000
committerMartin Schwidefsky <schwidefsky@de.ibm.com>2013-07-01 17:31:18 +0200
commit1fbdb8be9bfc91efd45720493c7ecae884ae22bd (patch)
tree0862b4abdf089eb5ad613d3470b03d54fed868ca
parent1f1ee9ad6b298400c7a44f860231ac1d3cb7bfd6 (diff)
downloadtalos-obmc-linux-1fbdb8be9bfc91efd45720493c7ecae884ae22bd.tar.gz
talos-obmc-linux-1fbdb8be9bfc91efd45720493c7ecae884ae22bd.zip
s390/dasd: process all requests in the device tasklet
Originally the DASD device tasklet would process the entries on the ccw_queue until the first non-final request was found. Which was okay as long as all requests have the same retries and expires parameter. However, as we're now allowing to modify both it is possible to have requests _after_ the first request which already have expired. So we need to check all requests in the device tasklet. Signed-off-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Stefan Weinhuber <wein@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
-rw-r--r--drivers/s390/block/dasd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/s390/block/dasd.c b/drivers/s390/block/dasd.c
index 498548980d78..000e5140bda4 100644
--- a/drivers/s390/block/dasd.c
+++ b/drivers/s390/block/dasd.c
@@ -1787,11 +1787,11 @@ static void __dasd_device_process_ccw_queue(struct dasd_device *device,
list_for_each_safe(l, n, &device->ccw_queue) {
cqr = list_entry(l, struct dasd_ccw_req, devlist);
- /* Stop list processing at the first non-final request. */
+ /* Skip any non-final request. */
if (cqr->status == DASD_CQR_QUEUED ||
cqr->status == DASD_CQR_IN_IO ||
cqr->status == DASD_CQR_CLEAR_PENDING)
- break;
+ continue;
if (cqr->status == DASD_CQR_ERROR) {
__dasd_device_recovery(device, cqr);
}
OpenPOWER on IntegriCloud