diff options
author | Dongho Sim <dh.sim@samsung.com> | 2014-07-30 06:52:41 +0000 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2014-07-30 15:38:59 -0700 |
commit | 33be828ada7274ebcade2001f16e5b4e33a4636e (patch) | |
tree | 52cd85e9e0f6eb23c68ab6a75ad904603381c19d /.mailmap | |
parent | 24a9ee0fa3d40415765d2d9f6064930d72ad8b5a (diff) | |
download | talos-obmc-linux-33be828ada7274ebcade2001f16e5b4e33a4636e.tar.gz talos-obmc-linux-33be828ada7274ebcade2001f16e5b4e33a4636e.zip |
f2fs: remove redundant lines in allocate_data_block
There are redundant lines in allocate_data_block.
In this function, we call refresh_sit_entry with old seg and old curseg.
After that, we call locate_dirty_segment with old curseg.
But, the new address is always allocated from old curseg and
we call locate_dirty_segment with old curseg in refresh_sit_entry.
So, we do not need to call locate_dirty_segment with old curseg again.
We've discussed like below:
Jaegeuk said:
"When considering SSR, we need to take care of the following scenario.
- old segno : X
- new address : Z
- old curseg : Y
This means, a new block is supposed to be written to Z from X.
And Z is newly allocated in the same path from Y.
In that case, we should trigger locate_dirty_segment for Y, since
it was a current_segment and can be dirty owing to SSR.
But that was not included in the dirty list."
Changman said:
"We already choosed old curseg(Y) and then we allocate new address(Z) from old
curseg(Y). After that we call refresh_sit_entry(old address, new address).
In the funcation, we call locate_dirty_segment with old seg and old curseg.
So calling locate_dirty_segment after refresh_sit_entry again is redundant."
Jaegeuk said:
"Right. The new address is always allocated from old_curseg."
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Dongho Sim <dh.sim@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions