talos-obmc-linux/net, branch dev-4.10

net/ncsi: Don't return error on normal response

2017-11-14T02:23:11+00:00

Several response handlers return EBUSY if the data corresponding to the command/response pair is already set. There is no reason to return an error here; the channel is advertising something as enabled because we told it to enable it, and it's possible that the feature has been enabled previously. Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: David S. Miller (cherry picked from commit 04bad8bda9e25afe676a6f4452f3b304c1fdea16) Signed-off-by: Joel Stanley

net/ncsi: Improve general state logging

2017-11-14T02:23:11+00:00

The NCSI driver is mostly silent which becomes a headache when trying to determine what has occurred on the NCSI connection. This adds additional logging in a few key areas such as state transitions and calling out certain errors more visibly. Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: David S. Miller (cherry picked from commit 9ef8690be13d8ae3130749fbcc0cc21e4e3f738c) Signed-off-by: Joel Stanley

Revert "net/ncsi: General state debugging"

2017-11-14T02:22:58+00:00

This reverts commit 61f3b32bd16707a18c2ff8ed23c8dafa7706fc6f. We will take the upstream version of this patch. OpenBMC-Staging-Count: 1 Signed-off-by: Joel Stanley

net/ncsi: General state debugging

2017-11-08T04:43:06+00:00

While relatively noisy this helps to debug NCSI state transitions and the state of channels beyond the existing "down" or "up" messages that the driver currently has. OpenBMC-Staging-Count: 1 Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: Joel Stanley

net/ncsi: Fix length of GVI response packet

2017-10-24T00:31:06+00:00

The length of GVI (GetVersionInfo) response packet should be 40 instead of 36. This issue was found from /sys/kernel/debug/ncsi/eth0/stats. # ethtool --ncsi eth0 swstats : RESPONSE OK TIMEOUT ERROR ======================================= GVI 0 0 2 With this applied, no error reported on GVI response packets: # ethtool --ncsi eth0 swstats : RESPONSE OK TIMEOUT ERROR ======================================= GVI 2 0 0 Signed-off-by: Gavin Shan Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: David S. Miller (cherry picked from commit 0a90e251988ceedc528c8db98f25b051cf190f44) Signed-off-by: Andrew Jeffery

net/ncsi: Enforce failover on link monitor timeout

2017-10-24T00:31:05+00:00

The NCSI channel has been configured to provide service if its link monitor timer is enabled, regardless of its state (inactive or active). So the timeout event on the link monitor indicates the out-of-service on that channel, for which a failover is needed. This sets NCSI_DEV_RESHUFFLE flag to enforce failover on link monitor timeout, regardless the channel's original state (inactive or active). Also, the link is put into "down" state to give the failing channel lowest priority when selecting for the active channel. The state of failing channel should be set to active in order for deinitialization and failover to be done. Signed-off-by: Gavin Shan Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: David S. Miller (cherry picked from commit 52b4c8627f9f0d882e969967a207a27a80c9c753) Signed-off-by: Andrew Jeffery

net/ncsi: Disable HWA mode when no channels are found

2017-10-24T00:31:05+00:00

When there are no NCSI channels probed, HWA (Hardware Arbitration) mode is enabled. It's not correct because HWA depends on the fact: NCSI channels exist and all of them support HWA mode. This disables HWA when no channels are probed. Signed-off-by: Gavin Shan Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: David S. Miller (cherry picked from commit 100ef01f3ea4badbee6479290a41f74abd0e523f) Signed-off-by: Andrew Jeffery

net/ncsi: Stop monitor if channel times out or is inactive

2017-10-24T00:31:04+00:00

ncsi_channel_monitor() misses stopping the channel monitor in several places that it should, causing a WARN_ON_ONCE() to trigger when the monitor is re-started later, eg: [ 459.040000] WARNING: CPU: 0 PID: 1093 at net/ncsi/ncsi-manage.c:269 ncsi_start_channel_monitor+0x7c/0x90 [ 459.040000] CPU: 0 PID: 1093 Comm: kworker/0:3 Not tainted 4.10.17-gaca2fdd #140 [ 459.040000] Hardware name: ASpeed SoC [ 459.040000] Workqueue: events ncsi_dev_work [ 459.040000] [<80010094>] (unwind_backtrace) from [<8000d950>] (show_stack+0x20/0x24) [ 459.040000] [<8000d950>] (show_stack) from [<801dbf70>] (dump_stack+0x20/0x28) [ 459.040000] [<801dbf70>] (dump_stack) from [<80018d7c>] (__warn+0xe0/0x108) [ 459.040000] [<80018d7c>] (__warn) from [<80018e70>] (warn_slowpath_null+0x30/0x38) [ 459.040000] [<80018e70>] (warn_slowpath_null) from [<803f6a08>] (ncsi_start_channel_monitor+0x7c/0x90) [ 459.040000] [<803f6a08>] (ncsi_start_channel_monitor) from [<803f7664>] (ncsi_configure_channel+0xdc/0x5fc) [ 459.040000] [<803f7664>] (ncsi_configure_channel) from [<803f8160>] (ncsi_dev_work+0xac/0x474) [ 459.040000] [<803f8160>] (ncsi_dev_work) from [<8002d244>] (process_one_work+0x1e0/0x450) [ 459.040000] [<8002d244>] (process_one_work) from [<8002d510>] (worker_thread+0x5c/0x570) [ 459.040000] [<8002d510>] (worker_thread) from [<80033614>] (kthread+0x124/0x164) [ 459.040000] [<80033614>] (kthread) from [<8000a5e8>] (ret_from_fork+0x14/0x2c) This also updates the monitor instead of just returning if ncsi_xmit_cmd() fails to send the get-link-status command so that the monitor properly times out. Fixes: e6f44ed6d04d3 "net/ncsi: Package and channel management" Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: David S. Miller (cherry picked from commit 0795fb2021f07969949f523ea33c39785bfae9d6) Signed-off-by: Andrew Jeffery

net/ncsi: Fix AEN HNCDSC packet length

2017-10-24T00:31:04+00:00

Correct the value of the HNCDSC AEN packet. Fixes: 7a82ecf4cfb85 "net/ncsi: NCSI AEN packet handler" Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: David S. Miller (cherry picked from commit 6850d0f8b2542112629061808ed950b35eb982e4) Signed-off-by: Andrew Jeffery

net/ncsi: Don't limit vids based on hot_channel

2017-10-24T00:31:03+00:00

Currently we drop any new VLAN ids if there are more than the current (or last used) channel can support. Most importantly this is a problem if no channel has been selected yet, resulting in a segfault. Secondly this does not necessarily reflect the capabilities of any other channels. Instead only drop a new VLAN id if we are already tracking the maximum allowed by the NCSI specification. Per-channel limits are already handled by ncsi_add_filter(), but add a message to set_one_vid() to make it obvious that the channel can not support any more VLAN ids. Signed-off-by: Samuel Mendoza-Jonas Signed-off-by: David S. Miller (cherry picked from commit 6e9c0075409d4ec1bc63558ee5a93916a6d7d16f) Signed-off-by: Andrew Jeffery