talos-obmc-linux/drivers, branch dev-5.0

hwmon: (pmbus/isl68137): Update ISL68137 to upstream

2019-04-19T02:29:09+00:00

Apply differences from hwmon review to bring the driver code to the same point. There were some key differences regarding attribute placement from the review, beyond the normal cleanup. OpenBMC-Staging-Count: 1 Signed-off-by: Patrick Venture [AJ: Rework subject] Signed-off-by: Andrew Jeffery

pmbus: support for custom sysfs attributes

2019-04-19T02:27:48+00:00

This patch makes it possible to pass custom struct attribute_group array via the pmbus_driver_info struct so that those can be added to the attribute groups passed to hwmon_device_register_with_groups(). This makes it possible to register custom sysfs attributes by PMBUS drivers similar to how you can do this with most other busses/classes. Signed-off-by: Krzysztof Adamski Signed-off-by: Guenter Roeck Signed-off-by: Andrew Jeffery

Revert "mtd: spi-nor: aspeed: use memcpy_fromio() to capture the optimization buffer"

2019-04-19T00:56:52+00:00

This reverts commit cb8980080ccb7879c5a8ef0e3efa783c9288d907. From Milton: > NACK > > [The] justifcation is false. The routine reads the whole buffer > because it calls the _rep routine and takes the size. > > In addition, the comment just before aspeed_smc_read_from_ahb > tells why memcpy_fromio and memcpy_toio are broken on 32 bit > arm, and this is still the case judging from the recent bug > reportfrom a Nuvoton user [1]. > > [1] https://github.com/openbmc/openbmc/issues/3521 OpenBMC-Staging-Count: 1 Signed-off-by: Andrew Jeffery

hwmon (occ): Add temp sensor value check

2019-04-18T01:45:19+00:00

The occ driver supports two formats for the temp sensor value. The OCC firmware for P8 supports only the first format, for which no range checking or error processing is performed in the driver. Inspecting the OCC sources for P8 reveals that OCC may send a special value 0xFFFF to indicate that a sensor read timeout has occurred, see https://github.com/open-power/occ/blob/master_p8/src/occ/cmdh/cmdh_fsp_cmds.c#L395 That situation wasn't handled in the driver. This patch adds invalid temp value check for the sensor data format 1 and handles it the same way as it is done for the format 2, where EREMOTEIO is reported for this case. Signed-off-by: Alexander Soldatov Signed-off-by: Alexander Amelkin Reviewed-by: Alexander Amelkin Cc: Edward A. James Cc: Joel Stanley Reviewed-by: Eddie James

mtd: spi-nor: aspeed: add support for the 4B opcodes

2019-04-18T01:41:23+00:00

Switch the default controller value to use the read mode in order to customize the command and use SPINOR_OP_READ_4B (0x13) when the chip supports 4B opcodes. OpenBMC-Staging-Count: 1 Signed-off-by: Cédric Le Goater Signed-off-by: Andrew Jeffery

mtd: spi-nor: aspeed: use memcpy_fromio() to capture the optimization buffer

2019-04-18T01:41:20+00:00

aspeed_smc_read_from_ahb() only reads the first word which is not what we want. We want to capture a CALIBRATE_BUF_SIZE size window of the flash contents to optimize the read. OpenBMC-Staging-Count: 1 Signed-off-by: Cédric Le Goater Signed-off-by: Andrew Jeffery

mtd: spi-nor: aspeed: clarify 4BYTE address mode mask

2019-04-18T01:41:15+00:00

OpenBMC-Staging-Count: 1 Signed-off-by: Cédric Le Goater Signed-off-by: Andrew Jeffery

mtd: spi-nor: aspeed: introduce a aspeed_smc_default_read() helper

2019-04-18T01:41:12+00:00

OpenBMC-Staging-Count: 1 Signed-off-by: Cédric Le Goater Signed-off-by: Andrew Jeffery

hwmon (occ): Prevent sysfs error attribute from returning error

2019-04-18T01:41:09+00:00

The error sysfs attribute returns the stored error state of the OCC and doesn't depend on the OCC poll response. Therefore, split the error attribute into it's own function to avoid failing out of the function if the poll response fails. OpenBMC-Staging-Count: 1 Signed-off-by: Eddie James Signed-off-by: Andrew Jeffery

hwmon (occ): Store error condition for rate-limited polls

2019-04-18T01:41:05+00:00

The OCC driver limits the rate of sending poll commands to the OCC. If a user reads a hwmon entry after a poll response resulted in an error and is rate-limited, the error is invisible to the user. Fix this by storing the last error and returning that in the rate-limited case. OpenBMC-Staging-Count: 1 Signed-off-by: Eddie James Signed-off-by: Andrew Jeffery