From ffc30dcc91342c28a6255a86341ae40317300345 Mon Sep 17 00:00:00 2001 From: Benjamin Weisenbeck Date: Mon, 5 Feb 2018 14:17:36 -0600 Subject: PRD: Disabling FSP clearing/masking of FIRs to avoid blacklist violations Change-Id: I116a504aff84defd163abc6f4b970ef4859511f7 CQ: SW413344 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53397 Tested-by: Jenkins Server Reviewed-by: Caleb N Palmer Reviewed-by: Brian J Stegmiller Reviewed-by: Zane C Shelley Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53493 Reviewed-by: Zane C. Shelley Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins --- src/usr/diag/prdf/common/framework/register/prdfResetErrorRegister.C | 5 ++++- src/usr/diag/prdf/common/rule/prdfRuleMetaData.C | 5 +++++ 2 files changed, 9 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/usr/diag/prdf/common/framework/register/prdfResetErrorRegister.C b/src/usr/diag/prdf/common/framework/register/prdfResetErrorRegister.C index b1da2c317..5895f4697 100755 --- a/src/usr/diag/prdf/common/framework/register/prdfResetErrorRegister.C +++ b/src/usr/diag/prdf/common/framework/register/prdfResetErrorRegister.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2012,2017 */ +/* Contributors Listed Below - COPYRIGHT 2012,2018 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -116,6 +116,8 @@ ResetAndMaskErrorRegister::Reset(const BitKey & bit_list, SyncAnalysis (sdc); //Add call to Sync SDC #endif + // We're not allowed to clear black-listed FIRs from the FSP + #if defined(__HOSTBOOT_MODULE) || defined(ESW_SIM_COMPILE) rc = ErrorRegisterMask::Reset(bit_list,error); //undo filters // Mask registers as needed, if at threshold. @@ -136,6 +138,7 @@ ResetAndMaskErrorRegister::Reset(const BitKey & bit_list, { rc |= i->op->Reset(bit_list, error, i->read, i->write); } + #endif } return rc; diff --git a/src/usr/diag/prdf/common/rule/prdfRuleMetaData.C b/src/usr/diag/prdf/common/rule/prdfRuleMetaData.C index ae4fcb973..acff8809f 100644 --- a/src/usr/diag/prdf/common/rule/prdfRuleMetaData.C +++ b/src/usr/diag/prdf/common/rule/prdfRuleMetaData.C @@ -469,6 +469,10 @@ int32_t RuleMetaData::Analyze( STEP_CODE_DATA_STRUCT & i_serviceData, #ifndef __HOSTBOOT_MODULE SyncAnalysis (i_sdc); //mp01 Add call to Sync SDC #endif + + // We're not allowed to clear black-listed FIRs from the FSP + #if defined(__HOSTBOOT_MODULE) || defined(ESW_SIM_COMPILE) + // Call mask plugin. if (i_serviceData.service_data->IsAtThreshold()) { @@ -485,6 +489,7 @@ int32_t RuleMetaData::Analyze( STEP_CODE_DATA_STRUCT & i_serviceData, (*l_reset)( l_chipAnalyzed, PluginDef::bindParm(i_serviceData) ); //@pw01 + #endif } // Additional error isolation for HWPs, if needed. -- cgit v1.2.1