From ff05444dd46091a9a666ce1b47c04d12071ac6fa Mon Sep 17 00:00:00 2001 From: Louis Stermole Date: Fri, 6 Sep 2019 15:38:07 -0400 Subject: Remove unmask of MCBISTFIRQ[12] This FIR bit was only used for a DD1.x workaround, and the PRD code to handle it had already been removed from FW. We thought we would need this FIR to implement the symbol mark performance workaround in commit 70081 (CQ SW453101) but we didn't end up needing it. As a result of unmasking this, there have been erroneous error logs appearing in manufacturing tests. Change-Id: I9ce1d563280b889609d2b0a6301ed82bd8540ba0 CQ: SW475386 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83429 Tested-by: FSP CI Jenkins Dev-Ready: Louis Stermole Reviewed-by: STEPHEN GLANCY Reviewed-by: Mark Pizzutillo Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: Jennifer A Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83435 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M Crowell --- .../chips/p9/procedures/hwp/memory/lib/fir/unmask.C | 2 -- .../hwp/memory/lib/workarounds/mcbist_workarounds.C | 20 -------------------- .../hwp/memory/lib/workarounds/mcbist_workarounds.H | 8 -------- 3 files changed, 30 deletions(-) (limited to 'src') diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/fir/unmask.C b/src/import/chips/p9/procedures/hwp/memory/lib/fir/unmask.C index 798ae3b08..744e7412f 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/fir/unmask.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/fir/unmask.C @@ -82,8 +82,6 @@ fapi2::ReturnCode after_draminit_mc( const fapi2::Target(i_target)) { fir::reg l_mca_fir_reg(p, l_rc); diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C b/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C index e172dfbdb..f87d01078 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C +++ b/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C @@ -146,26 +146,6 @@ fapi2::ReturnCode end_of_rank( const fapi2::Target& i_target return fapi2::FAPI2_RC_SUCCESS; } -/// -/// @brief WAT debug attention -/// For Nimbus DD1 the MCBIST engine uses the WAT debug bit as a workaround -/// For Nimbus DD2 the WAT debug bit is used for a different workaround -/// @param[in] i_target the fapi2 target of the mcbist -/// @return fapi2::ReturnCode FAPI2_RC_SUCCESS if ok -/// -fapi2::ReturnCode wat_debug_attention( const fapi2::Target& i_target ) -{ - // MCBIST attentions are already special attention - fapi2::ReturnCode l_rc; - fir::reg mcbist_fir_register(i_target, l_rc); - FAPI_TRY(l_rc, "unable to create fir::reg for %d", MCBIST_MCBISTFIRQ); - - FAPI_TRY(mcbist_fir_register.attention().write()); - -fapi_try_exit: - return fapi2::current_err; -} - /// /// @brief BROADCAST OUT OF SYNC workaround /// A UE noise window is triggered by UE/AUEs causing an out of sync error diff --git a/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.H b/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.H index 166ecb20f..7a4533c6d 100644 --- a/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.H +++ b/src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.H @@ -71,14 +71,6 @@ void replace_read_helper(mss::mcbist::program<>& i_program); fapi2::ReturnCode end_of_rank( const fapi2::Target& i_target, mss::mcbist::program<>& i_program ); -/// -/// @brief WAT debug attention -/// For Nimbus DD1 the MCBIST engine uses the WAT debug bit as a workaround -/// @param[in] i_target the fapi2 target of the mcbist -/// @return fapi2::ReturnCode FAPI2_RC_SUCCESS if ok -/// -fapi2::ReturnCode wat_debug_attention( const fapi2::Target& i_target ); - /// /// @brief BROADCAST OUT OF SYNC workaround /// A UE noise window is triggered by UE/AUEs causing an out of sync error -- cgit v1.2.3