From e8ac167fca7ba17db843fb16174b32f0f90c497d Mon Sep 17 00:00:00 2001 From: Dan Crowell Date: Wed, 16 Aug 2017 15:23:56 -0500 Subject: Fix off-by-one error in LPC driver for pnor mbox windows Found a bug where we fail if we use a window all the way up to the edge of the allocated window. Change-Id: I1e663089a3ba6b2e4d9a7dbc67ae98db0fd2524e CQ: SW398471 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/44703 Reviewed-by: Prachi Gupta Tested-by: Jenkins Server Reviewed-by: Daniel M. Crowell --- src/usr/lpc/lpcdd.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/usr/lpc/lpcdd.C b/src/usr/lpc/lpcdd.C index e10d3c975..b0dd00fd7 100644 --- a/src/usr/lpc/lpcdd.C +++ b/src/usr/lpc/lpcdd.C @@ -777,7 +777,7 @@ errlHndl_t LpcDD::_readLPC(LPC::TransType i_type, *o_ptr = *l_ptr; } else if ( i_type == LPC::TRANS_FW - && (i_addr + io_buflen) < LPC::FW_WINDOW_SIZE) + && (i_addr + io_buflen) <= LPC::FW_WINDOW_SIZE) { memcpy( o_buffer, reinterpret_cast(l_addr), io_buflen ); } -- cgit v1.2.3