From 3cf1a8dc6cd876d2db861317b62760992594c6d2 Mon Sep 17 00:00:00 2001 From: Christian Geddes Date: Mon, 22 Apr 2019 14:25:41 -0500 Subject: Ignore CRC errors for Hostboot during Axone bringup There is some confusion on what order the bytes should be processed for calculateing the CRC for inband communication. For now we will ignore CRC errors for inband communication in hostboot. This will allow us to test HWPs while simics team get endianess figured out. Change-Id: I3aeb8acdf1781f0873b1fc1ea9df431ea40ac767 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76348 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: Louis Stermole Reviewed-by: CALEB SCHLOSSIN Reviewed-by: Jennifer A. Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76357 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Christian R. Geddes --- src/import/chips/ocmb/explorer/procedures/hwp/memory/exp_inband.C | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/import/chips/ocmb/explorer/procedures/hwp/memory/exp_inband.C b/src/import/chips/ocmb/explorer/procedures/hwp/memory/exp_inband.C index ff24bc76c..3c092f84c 100644 --- a/src/import/chips/ocmb/explorer/procedures/hwp/memory/exp_inband.C +++ b/src/import/chips/ocmb/explorer/procedures/hwp/memory/exp_inband.C @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2018 */ +/* Contributors Listed Below - COPYRIGHT 2018,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -443,6 +443,8 @@ fapi2::ReturnCode host_fw_response_struct_from_little_endian(const fapi2::Target "%s Failed to convert from data to host_fw_response_struct data size %u expected size %u", mss::c_str(i_target), i_data.size(), sizeof(host_fw_response_struct)); +//TODO CQ: SW461052 Correct MMIO CRC responses +#ifndef CONFIG_AXONE_BRING_UP FAPI_ASSERT(l_crc == o_response.response_header_crc, fapi2::EXP_INBAND_RSP_CRC_ERR() .set_COMPUTED(l_crc) @@ -450,6 +452,7 @@ fapi2::ReturnCode host_fw_response_struct_from_little_endian(const fapi2::Target .set_OCMB_TARGET(i_target), "%s Response CRC failed to validate computed: 0x%08x got: 0x%08x", mss::c_str(i_target), l_crc, o_response.response_header_crc); +#endif fapi_try_exit: return fapi2::current_err; -- cgit v1.2.1