From 0921b80a52a9cfd44186e0160d3dfae538746170 Mon Sep 17 00:00:00 2001 From: Mark Pizzutillo Date: Fri, 6 Dec 2019 15:17:15 -0500 Subject: Add new DDIMM spd version 0_3 and update UTs Change-Id: I0517bebd0514f0c073e424dc786be7352113c1f8 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/88225 Tested-by: FSP CI Jenkins Tested-by: Jenkins Server Tested-by: Hostboot CI Reviewed-by: Louis Stermole Reviewed-by: STEPHEN GLANCY Reviewed-by: ANDRE A MARIN Dev-Ready: Mark Pizzutillo Tested-by: PPE CI Reviewed-by: Jennifer A Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/88233 Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Reviewed-by: Daniel M Crowell --- src/import/generic/memory/lib/spd/spd_factory_pattern.H | 13 +++++++++++-- .../generic/memory/lib/utils/shared/mss_generic_consts.H | 3 ++- 2 files changed, 13 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/import/generic/memory/lib/spd/spd_factory_pattern.H b/src/import/generic/memory/lib/spd/spd_factory_pattern.H index 567ce2d82..278fdf09d 100644 --- a/src/import/generic/memory/lib/spd/spd_factory_pattern.H +++ b/src/import/generic/memory/lib/spd/spd_factory_pattern.H @@ -5,7 +5,7 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* Contributors Listed Below - COPYRIGHT 2018 */ +/* Contributors Listed Below - COPYRIGHT 2018,2019 */ /* [+] International Business Machines Corp. */ /* */ /* */ @@ -219,7 +219,8 @@ class module_factory RDIMM_DDR4_REV_1_1 { DDR4, RDIMM_MODULE, rev::V1_1}, NVDIMM_DDR4_REV_1_0{ DDR4, NVDIMM_MODULE, rev::V1_0}, NVDIMM_DDR4_REV_1_1{ DDR4, NVDIMM_MODULE, rev::V1_1}, - DDIMM_DDR4_REV_0_0 { DDR4, DDIMM_MODULE, rev::V0_0} + DDIMM_DDR4_REV_0_0 { DDR4, DDIMM_MODULE, rev::V0_0}, + DDIMM_DDR4_REV_0_3 { DDR4, DDIMM_MODULE, rev::V0_3} { // Setup pre-defined maps available to search through init_map_vars(i_spd_data, iv_decoder_map); @@ -270,6 +271,7 @@ class module_factory const module_key NVDIMM_DDR4_REV_1_0; const module_key NVDIMM_DDR4_REV_1_1; const module_key DDIMM_DDR4_REV_0_0; + const module_key DDIMM_DDR4_REV_0_3; std::map< module_key, std::shared_ptr > iv_decoder_map; @@ -329,6 +331,10 @@ class module_factory // Rev 0.0 // DDIMMs start out life w/the updated general section o_map[DDIMM_DDR4_REV_0_0] = std::make_shared< decoder >(iv_target, i_spd_data); + + // Remains mostly the same. New thermal sensor fields and pmic redundancy fields + o_map[DDIMM_DDR4_REV_0_3] = std::make_shared< decoder >(iv_target, i_spd_data); + } /// @@ -375,6 +381,9 @@ class module_factory // Rev 0.0 // Life starts out at base revision level o_map[DDIMM_DDR4_REV_0_0] = std::make_shared< decoder >(iv_target, i_spd_data); + + // Remains mostly the same. New thermal sensor fields and pmic redundancy fields + o_map[DDIMM_DDR4_REV_0_3] = std::make_shared< decoder >(iv_target, i_spd_data); } /// diff --git a/src/import/generic/memory/lib/utils/shared/mss_generic_consts.H b/src/import/generic/memory/lib/utils/shared/mss_generic_consts.H index 3b4c7c073..414274469 100644 --- a/src/import/generic/memory/lib/utils/shared/mss_generic_consts.H +++ b/src/import/generic/memory/lib/utils/shared/mss_generic_consts.H @@ -865,6 +865,7 @@ namespace spd enum rev : uint8_t { V0_0 = 0x00, ///< represents Rev 0.0 + V0_3 = 0x03, ///< represents Rev 0.3 V1_0 = 0x10, ///< represents Rev 1.0 V1_1 = 0x11, ///< represents Rev 1.1 V1_2 = 0x12, ///< represents Rev 1.2 @@ -874,7 +875,7 @@ enum rev : uint8_t GEN_SEC_MAX = V1_1, RDIMM_MAX = V1_1, LRDIMM_MAX = V1_2, - DDIMM_MAX = V0_0, + DDIMM_MAX = V0_3, }; /// -- cgit v1.2.1