From caaafc02d5887c1ab777466c9609cdd4f25ed7fd Mon Sep 17 00:00:00 2001 From: Dan Crowell Date: Mon, 29 Jan 2018 12:39:58 -0600 Subject: Commit errors for VPD writes as visible logs The basic path should be working now so we need to stop hiding error logs we generate in the VPD write message path. Change-Id: Iaa53d7a2e2d2444981d62f71d80ed9f8b844a0d1 RTC: 180490 Backport: fips910 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52846 Tested-by: Jenkins Server Tested-by: Jenkins OP Build CI Tested-by: Jenkins OP HW Tested-by: FSP CI Jenkins Reviewed-by: Christian R. Geddes Reviewed-by: Daniel M. Crowell --- src/usr/vpd/runtime/rt_vpd.C | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/usr/vpd') diff --git a/src/usr/vpd/runtime/rt_vpd.C b/src/usr/vpd/runtime/rt_vpd.C index 2f9cdffe9..42d7f0fa6 100644 --- a/src/usr/vpd/runtime/rt_vpd.C +++ b/src/usr/vpd/runtime/rt_vpd.C @@ -516,11 +516,10 @@ errlHndl_t sendMboxWriteMsg ( size_t i_numBytes, if( l_resp_fw_msg ) { free(l_resp_fw_msg); } l_req_fw_msg = l_resp_fw_msg = nullptr; + // Commit any errors we get in here because we'd like the main + // function to complete even if we can't send the data out if (l_err) { - // @fixme-RTC:180490 - Temporarily commit until FSP code is implemented - // Just commit the log for now until FSP code is implemented - l_err->setSev(ERRORLOG::ERRL_SEV_INFORMATIONAL); errlCommit( l_err, VPD_COMP_ID ); } -- cgit v1.2.1